Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
mruby
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Libraries
mruby
Commits
f6c9e40d
Commit
f6c9e40d
authored
Mar 01, 2013
by
Daniel Bovensiepen
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Modification of CONTRIBUTING.md
Some minor fixes of the CONTRIBUTING.md file.
parent
12af0401
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
8 deletions
+8
-8
CONTRIBUTING.md
CONTRIBUTING.md
+8
-8
No files found.
CONTRIBUTING.md
View file @
f6c9e40d
# How to contribute
mruby is an open-source project which is looking forward to each contribution.
mruby is an open-source project which is looking forward to each contribution.
## Your Pull Request
...
...
@@ -8,10 +8,10 @@ To make it easy to review and understand your change please keep the following
things in mind before submitting your pull request:
*
Work on the latest possible state of
**mruby/master**
*
Test your changes before creating a pull request (
**make test**
)
*
Create a branch which is dedicated to your change
*
Test your changes before creating a pull request (
```./minirake test```
)
*
If possible write a test case which confirms your change
*
Don't mix several features or bug-fixes in one pull request
*
Create a branch which is dedicated to your change
*
Create a meaningful commit message
*
Explain your change (i.e. with a link to the issue you are fixing)
...
...
@@ -27,16 +27,16 @@ C code:
#### Comply with C99 (ISO/IEC 9899:1999)
mruby should be highly portable to other systems and compilers. For th
at
it is
mruby should be highly portable to other systems and compilers. For th
is
it is
recommended to keep your code as close as possible to the C99 standard
(http://www.open-std.org/jtc1/sc22/WG14/www/docs/n1256.pdf).
Although we target C99, V
C is also an important target for mruby, so that we
avoid local variable declaration
in the middle.
Although we target C99, V
isual C++ is also an important target for mruby, so
you should local variable declarations
in the middle.
#### Reduce library dependencies to a minimum
The dependencies to libraries should be
pu
t to an absolute minimum. This
The dependencies to libraries should be
kep
t to an absolute minimum. This
increases the portability but makes it also easier to cut away parts of mruby
on-demand.
...
...
@@ -56,7 +56,7 @@ Use C++ style comments only for temporary comment e.g. commenting out some code
### Ruby code
Parts of the standard library of mruby
is
written in the Ruby programming language
Parts of the standard library of mruby
are
written in the Ruby programming language
itself. Please note the following hints for your Ruby code:
#### Comply with the Ruby standard (ISO/IEC 30170:2012)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment