1. 16 Nov, 2015 3 commits
    • Zachary Scott's avatar
      31a8743d
    • Yukihiro "Matz" Matsumoto's avatar
      Merge pull request #3013 from zzak/dont-pull-gems-by-default · 916630be
      Yukihiro "Matz" Matsumoto authored
      This patch changes git gem behavior to never pull gems unless specified.
      916630be
    • Zachary Scott's avatar
      This patch changes git gem behavior to never pull gems unless specified. · 98285e6b
      Zachary Scott authored
      Since mgem's function almost the same as git gems, but you can see they already
      avoid pulling from source after the gem has already been cloned.
      
       You can see from the `load_special_path_gem` method found in the file
      `mruby_build_gem.rake`, or extracted here:
      
      ```ruby
      if File.exist? mgem_list_dir
        git.run_pull mgem_list_dir, mgem_list_url if $pull_gems
      else
        FileUtils.mkdir_p mgem_list_dir
        git.run_clone mgem_list_dir, mgem_list_url, "--depth 1"
      end
      ```
      
      Also, later in this same method; mgem will set the `git` params.
      Doing this will trigger the following block:
      
      ```ruby
      if File.exist?(gemdir)
        if $pull_gems
          git.run_pull gemdir, url
        else
          gemdir
        end
      else
        # ... clone
      end
      ```
      
      You can see here, this checks if `$pull_gems` is enabled before pulling.
      
      Lastly, the final condition for this method is here:
      
      ```ruby
      if params[:checksum_hash]
        # Jump to the specified commit
        git.run_checkout gemdir, params[:checksum_hash]
      else
        # Jump to the top of the branch
        git.run_checkout gemdir, branch if $pull_gems
      end
      ```
      
      What we changed was the `else` condition of this block to follow the same
      behavior as the aforementioned code. In doing so, we can avoid two things:
      
      * Excess `clone` calls can slow down builds (times number of gems used)
      * We _don't_ want our code to _update_ during build
      
      To explain, if during build time there are some changes in the gem we are
      depending upon: updating during compile time could actually break our
      application.
      
      This is what we're trying to avoid.
      98285e6b
  2. 14 Nov, 2015 6 commits
  3. 10 Nov, 2015 1 commit
  4. 09 Nov, 2015 3 commits
  5. 08 Nov, 2015 3 commits
  6. 07 Nov, 2015 1 commit
  7. 06 Nov, 2015 3 commits
    • cremno's avatar
      d109e5b4
    • cremno's avatar
      fix ambiguous first argument warning · bb141e55
      cremno authored
      /home/travis/build/mruby/mruby/test/t/float.rb:201:17:
      ambiguous first argument; put parentheses or even spaces
      bb141e55
    • cremno's avatar
      remove return · e18e2a44
      cremno authored
      The return type of the mrb_objspace_each_objects function is void.
      So this return statement with an expression is unnecessary and
      also violates a constraint. From C99 §6.8.6.4:
      >A return statement with an expression shall not appear
      >in a function whose return type is void.
      e18e2a44
  8. 28 Oct, 2015 1 commit
  9. 26 Oct, 2015 1 commit
  10. 24 Oct, 2015 2 commits
  11. 21 Oct, 2015 12 commits
  12. 20 Oct, 2015 4 commits