1. 18 Nov, 2020 1 commit
  2. 17 Nov, 2020 8 commits
  3. 16 Nov, 2020 9 commits
  4. 15 Nov, 2020 4 commits
  5. 14 Nov, 2020 17 commits
  6. 13 Nov, 2020 1 commit
    • KOBAYASHI Shuji's avatar
      Simplify `MRuby::Command#_run` to avoid duplicated compilation · 0c55b85f
      KOBAYASHI Shuji authored
      ref: https://github.com/mruby/mruby/pull/4959#discussion_r402086196
      
      Compiles twice because it falls back to `build.filename(command)` when
      `command` fails. This process was added at 9968af45 to support `ccache gcc`
      etc. At that time, it seems that it was necessary because
      `build.filename(command)` quoted the whole `command`, but now it does not
      quote, so we can just run `build.filename(command)`.
      
      ### Example
      
        ```console
        $ echo 1 > src/a.c
        $ rake -v
        ```
      
      #### Before this patch:
      
        ```console
        (snip)
        gcc -std=gnu99 -g -O3 -Wall -Wundef -Wdeclaration-after-statement -Werror-implicit-function-declaration -Wwrite-strings -I"/mruby/mruby/include" -MMD -o "/mruby/mruby/build/host/src/a.o" -c "/mruby/mruby/src/a.c"
        /mruby/mruby/src/a.c:1:1: error: expected identifier or '('
        1
        ^
        1 error generated.
        gcc -std=gnu99 -g -O3 -Wall -Wundef -Wdeclaration-after-statement -Werror-implicit-function-declaration -Wwrite-strings -I"/mruby/mruby/include" -MMD -o "/mruby/mruby/build/host/src/a.o" -c "/mruby/mruby/src/a.c"
        /mruby/mruby/src/a.c:1:1: error: expected identifier or '('
        1
        ^
        1 error generated.
        rake aborted!
        (snip)
        ```
      
      #### After this patch:
      
        ```console
        (snip)
        gcc -std=gnu99 -g -O3 -Wall -Wundef -Wdeclaration-after-statement -Werror-implicit-function-declaration -Wwrite-strings -I"/mruby/mruby/include" -MMD -o "/mruby/mruby/build/host/src/a.o" -c "/mruby/mruby/src/a.c"
        /mruby/mruby/src/a.c:1:1: error: expected identifier or '('
        1
        ^
        1 error generated.
        rake aborted!
        (snip)
        ```
      0c55b85f