nghttpx: Ensure that cert serial does not exceed 20 bytes

11d0533c · Tatsuhiro Tsujikawa · dbb5f00d · 11d0533c
Commit 11d0533c authored Jan 05, 2019 by Tatsuhiro Tsujikawa
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

src/shrpx_tls.cc src/shrpx_tls.cc +1 -1

No files found.
--- a/src/shrpx_tls.cc
+++ b/src/shrpx_tls.cc
@@ -2042,7 +2042,7 @@ StringRef get_x509_serial(BlockAllocator &balloc, X509 *x) {
  auto sn = X509_get_serialNumber(x);
  auto bn = BN_new();
  auto bn_d = defer(BN_free, bn);
-  if (!ASN1_INTEGER_to_BN(sn, bn)) {
+  if (!ASN1_INTEGER_to_BN(sn, bn) || BN_num_bytes(bn) > 20) {
    return StringRef{};
  }