Skip to content

N
nghttp2
Commit 88add854 authored by Tatsuhiro Tsujikawa's avatar Tatsuhiro Tsujikawa
Browse files
Options

nghttpx: Treat malformed request as PROTOCOL_ERROR

parent 704bbbfc
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 9 deletions
src/shrpx_http2_upstream.cc
View file @ 88add854
......@@ -314,9 +314,7 @@ int on_request_headers(Http2Upstream *upstream,
}
if(!http2::check_http2_request_headers(nva)) {
if(upstream->error_reply(downstream, 400) != 0) {
upstream->rst_stream(downstream, NGHTTP2_PROTOCOL_ERROR);
}
upstream->rst_stream(downstream, NGHTTP2_PROTOCOL_ERROR);
return 0;
}
......@@ -336,9 +334,7 @@ int on_request_headers(Http2Upstream *upstream,
// Here we strictly require :authority header field.
if(scheme || path || !having_authority) {
if(upstream->error_reply(downstream, 400) != 0) {
upstream->rst_stream(downstream, NGHTTP2_PROTOCOL_ERROR);
}
upstream->rst_stream(downstream, NGHTTP2_PROTOCOL_ERROR);
return 0;
}
......@@ -351,9 +347,7 @@ int on_request_headers(Http2Upstream *upstream,
(!get_config()->http2_proxy && !having_authority && !having_host) ||
!http2::non_empty_value(path)) {
if(upstream->error_reply(downstream, 400) != 0) {
upstream->rst_stream(downstream, NGHTTP2_PROTOCOL_ERROR);
}
upstream->rst_stream(downstream, NGHTTP2_PROTOCOL_ERROR);
return 0;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment