Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
N
nghttp2
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Libraries
nghttp2
Commits
9f008330
Commit
9f008330
authored
Dec 20, 2015
by
Tatsuhiro Tsujikawa
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix strange use of session_detect_idle_stream
parent
dd93b293
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
1 deletion
+4
-1
lib/nghttp2_session.c
lib/nghttp2_session.c
+4
-1
No files found.
lib/nghttp2_session.c
View file @
9f008330
...
@@ -3429,6 +3429,8 @@ int nghttp2_session_on_request_headers_received(nghttp2_session *session,
...
@@ -3429,6 +3429,8 @@ int nghttp2_session_on_request_headers_received(nghttp2_session *session,
return
NGHTTP2_ERR_IGN_HEADER_BLOCK
;
return
NGHTTP2_ERR_IGN_HEADER_BLOCK
;
}
}
assert
(
session
->
server
);
if
(
!
session_is_new_peer_stream_id
(
session
,
frame
->
hd
.
stream_id
))
{
if
(
!
session_is_new_peer_stream_id
(
session
,
frame
->
hd
.
stream_id
))
{
/* The spec says if an endpoint receives a HEADERS with invalid
/* The spec says if an endpoint receives a HEADERS with invalid
stream ID, it MUST issue connection error with error code
stream ID, it MUST issue connection error with error code
...
@@ -3437,7 +3439,8 @@ int nghttp2_session_on_request_headers_received(nghttp2_session *session,
...
@@ -3437,7 +3439,8 @@ int nghttp2_session_on_request_headers_received(nghttp2_session *session,
Then connection error is too harsh. It means that we only use
Then connection error is too harsh. It means that we only use
connection error if stream ID refers idle stream. OTherwise we
connection error if stream ID refers idle stream. OTherwise we
just ignore HEADERS for now. */
just ignore HEADERS for now. */
if
(
session_detect_idle_stream
(
session
,
frame
->
hd
.
stream_id
))
{
if
(
frame
->
hd
.
stream_id
==
0
||
nghttp2_session_is_my_stream_id
(
session
,
frame
->
hd
.
stream_id
))
{
return
session_inflate_handle_invalid_connection
(
return
session_inflate_handle_invalid_connection
(
session
,
frame
,
NGHTTP2_ERR_PROTO
,
session
,
frame
,
NGHTTP2_ERR_PROTO
,
"request HEADERS: invalid stream_id"
);
"request HEADERS: invalid stream_id"
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment