src: Handle return value of getsockopt

b0e98718 · Tatsuhiro Tsujikawa · 3d4a4cb6 · b0e98718
Commit b0e98718 authored Apr 24, 2016 by Tatsuhiro Tsujikawa
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 5 deletions

src/util.cc src/util.cc +4 -5

No files found.
--- a/src/util.cc
+++ b/src/util.cc
@@ -882,12 +882,11 @@ int create_nonblock_socket(int family) {
 bool check_socket_connected(int fd) {
  int error;
  socklen_t len = sizeof(error);
-  if (getsockopt(fd, SOL_SOCKET, SO_ERROR, &error, &len) == 0) {
-    if (error != 0) {
-      return false;
-    }
+  if (getsockopt(fd, SOL_SOCKET, SO_ERROR, &error, &len) != 0) {
+    return false;
  }
-  return true;
+
+  return error == 0;
 }

 bool ipv6_numeric_addr(const char *host) {