Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
N
nghttp2
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Libraries
nghttp2
Commits
f14ac743
Commit
f14ac743
authored
Dec 10, 2015
by
Tatsuhiro Tsujikawa
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
At least check stream ID is valid when PUSH_PROMISE is received in goaway mode
parent
0c70ff56
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
5 deletions
+6
-5
lib/nghttp2_session.c
lib/nghttp2_session.c
+6
-5
No files found.
lib/nghttp2_session.c
View file @
f14ac743
...
@@ -4121,17 +4121,18 @@ int nghttp2_session_on_push_promise_received(nghttp2_session *session,
...
@@ -4121,17 +4121,18 @@ int nghttp2_session_on_push_promise_received(nghttp2_session *session,
return
session_inflate_handle_invalid_connection
(
return
session_inflate_handle_invalid_connection
(
session
,
frame
,
NGHTTP2_ERR_PROTO
,
"PUSH_PROMISE: push disabled"
);
session
,
frame
,
NGHTTP2_ERR_PROTO
,
"PUSH_PROMISE: push disabled"
);
}
}
if
(
session
->
goaway_flags
)
{
/* We just dicard PUSH_PROMISE after GOAWAY is sent or
received. */
return
NGHTTP2_ERR_IGN_HEADER_BLOCK
;
}
if
(
!
nghttp2_session_is_my_stream_id
(
session
,
frame
->
hd
.
stream_id
))
{
if
(
!
nghttp2_session_is_my_stream_id
(
session
,
frame
->
hd
.
stream_id
))
{
return
session_inflate_handle_invalid_connection
(
return
session_inflate_handle_invalid_connection
(
session
,
frame
,
NGHTTP2_ERR_PROTO
,
"PUSH_PROMISE: invalid stream_id"
);
session
,
frame
,
NGHTTP2_ERR_PROTO
,
"PUSH_PROMISE: invalid stream_id"
);
}
}
if
(
session
->
goaway_flags
)
{
/* We just dicard PUSH_PROMISE after GOAWAY is sent or
received. */
return
NGHTTP2_ERR_IGN_HEADER_BLOCK
;
}
if
(
!
session_is_new_peer_stream_id
(
session
,
if
(
!
session_is_new_peer_stream_id
(
session
,
frame
->
push_promise
.
promised_stream_id
))
{
frame
->
push_promise
.
promised_stream_id
))
{
/* The spec says if an endpoint receives a PUSH_PROMISE with
/* The spec says if an endpoint receives a PUSH_PROMISE with
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment