Commit fc26f08a authored by Tatsuhiro Tsujikawa's avatar Tatsuhiro Tsujikawa

shrpx: Fix Proxy-Authorization is alwasy sent even if userinfo is empty

Surprisingly, field_set & UF_USERINFO is nonzero even if userinfo
component is empty string.
parent 78523c67
......@@ -328,9 +328,13 @@ int parse_config(const char *opt, const char *optarg)
std::string val;
if(u.field_set & UF_USERINFO) {
http::copy_url_component(val, &u, UF_USERINFO, optarg);
val = util::percentDecode(val.begin(), val.end());
set_config_str(&mod_config()->downstream_http_proxy_userinfo,
val.c_str());
// Surprisingly, u.field_set & UF_USERINFO is nonzero even if
// userinfo component is empty string.
if(!val.empty()) {
val = util::percentDecode(val.begin(), val.end());
set_config_str(&mod_config()->downstream_http_proxy_userinfo,
val.c_str());
}
}
if(u.field_set & UF_HOST) {
http::copy_url_component(val, &u, UF_HOST, optarg);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment