Commit eefc67e5 authored by lahiker42's avatar lahiker42

cleanups


git-svn-id: https://protobuf-c.googlecode.com/svn/trunk@79 00440858-1255-0410-a3e6-75ea37f81c3a
parent 84154742
...@@ -2,15 +2,17 @@ ...@@ -2,15 +2,17 @@
--- IMPORTANT TODO --- --- IMPORTANT TODO ---
---------------------- ----------------------
- provide example rpc - provide example rpc
- at least include extensions in Descriptor
- proper support for extensions - proper support for extensions
- slot for ranges in descriptor - slot for ranges in descriptor
- parent in descriptor - extends is implemented as c-style function
- "extends" is implemented as c-style derivation whose name is built from the package, the base message type-name
- cast macros? and the member. which takes the base message and returns the
- implement default values for most primitive types, value, if it is found in "unknown_values".
but not strings, bytes, or messages. - implement default values for strings, bytes, and messages.
- ensure enums are int-size - ensure enums are int-size
- message__init(...)
initializes all defaults -- points at static default values
for strings, bytes and submessages.
-------------------- --------------------
--- NEEDED TESTS --- --- NEEDED TESTS ---
...@@ -26,16 +28,7 @@ ...@@ -26,16 +28,7 @@
--------------------- ---------------------
Document: Document:
- services - services
- default value handling - default value handling [not implemented yet]
- note that the plan is to set the value to the default
for optional types, but NOT set has_* to TRUE.
That way, code can just ignore the has,
but we won't superfluously serialize the default value.
(Move this to the docs)
Also, for now, we won't init default values that require allocation.
- add to CAVEATS: defaults for messages, strings, bytes not initialized
by INIT macro. Rationale: would interfere with other allocator
systems... not clear if that's true.
- check over documentation again - check over documentation again
-------------------------- --------------------------
...@@ -61,13 +54,6 @@ Document: ...@@ -61,13 +54,6 @@ Document:
------------------------- -------------------------
- lifetime functions for messages: - lifetime functions for messages:
MESSAGE__INIT macro:
for static messages, doesn't handle defaults requiring allocation.
message__init_allocated_defaults (...)
for static messages, only touches default values that must
be allocated.
message__init(...)
initializes all defaults -- does allocations for strings etc
message__new() message__new()
return a new message using an allocator with standard allocation policy return a new message using an allocator with standard allocation policy
message__unpack_onto(...) message__unpack_onto(...)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment