1. 11 Jan, 2014 3 commits
    • Robert Edmonds's avatar
      protobuf_c_message_unpack(): initialize tmp.length_prefix_len · 596352bb
      Robert Edmonds authored
      this should silence Coverity #1153648, which complains because
      tmp.length_prefix_len is uninitialized for certain wire types when
      copied on line 2486:
      
          scanned_member_slabs[which_slab][in_slab_index++] = tmp;
      596352bb
    • Robert Edmonds's avatar
      ac71dd58
    • Robert Edmonds's avatar
      protobuf-c/: gratuitous style changes · c797b07e
      Robert Edmonds authored
      dave's original style drives me crazy. reformat the C code in
      protobuf-c/ with "indent -kr -i8" and manually reflow for readability.
      
      try to fit most lines in 80 columns, but due to the lengthy type and
      function names in protobuf-c, enforcing an 80 column rule would result
      in a lot of cramped statements, so try to fit lines in up to 100 columns
      if it would improve readability. (e.g., one <=100 column line is
      probably better than 3-4 <=80 column lines.)
      
      ultimately i'd like to adopt most of the recommendations in the linux
      coding style: https://www.kernel.org/doc/Documentation/CodingStyle.
      this commit gets us most of the kernel indentation and comment coding
      style recommendations. later commits will tackle style recommendations
      that require more intrusive changes: breaking up large functions,
      replacing macros that affect control flow (e.g., DO_ALLOC). this will
      hopefully facilitate review and make the code base easier to maintain.
      
      i ran the old and new versions of protobuf-c.c through something like:
      
        gcc -S -D__PRETTY_FUNCTION__=0 -D__FILE__=0 -D__LINE__=0 -Wall -O0 \
          -o protobuf-c.S -c protobuf-c.c
      
      and reviewed the diffs of the assembly output to spot any functions that
      changed, and went back to make sure that any differences were
      functionally equivalent.
      c797b07e
  2. 10 Jan, 2014 7 commits
  3. 21 Dec, 2013 2 commits
  4. 17 Dec, 2013 1 commit
  5. 09 Dec, 2013 2 commits
  6. 04 Dec, 2013 1 commit
  7. 02 Dec, 2013 1 commit
  8. 28 Nov, 2013 1 commit
  9. 27 Nov, 2013 3 commits
  10. 23 Nov, 2013 4 commits
  11. 22 Nov, 2013 1 commit
  12. 21 Nov, 2013 2 commits
  13. 20 Nov, 2013 4 commits
  14. 19 Nov, 2013 8 commits