1. 17 May, 2019 1 commit
  2. 11 Apr, 2019 4 commits
    • Robert Edmonds's avatar
      Merge pull request #369 from protobuf-c/edmonds/protobuf-reflection-typedef-test-fix · 9412830d
      Robert Edmonds authored
      t/generated-code2/cxx-generate-packed-data.cc: Fix build failure on newer protobuf
      9412830d
    • Robert Edmonds's avatar
      t/generated-code2/cxx-generate-packed-data.cc: Fix build failure on newer protobuf · 7456d162
      Robert Edmonds authored
      google::protobuf::Message::Reflection has been removed in newer versions
      of protobuf. The replacement is google::protobuf::Reflection.
      
      protobuf in commit 779f61c6a3ce02a119e28e802f229e61b69b9046 ("Integrate
      recent changes from google3.", from August 2008) changed the following
      in message.h:
      
          @@ -336,7 +337,8 @@ class LIBPROTOBUF_EXPORT Message {
      
             // Introspection ---------------------------------------------------
      
          -  class Reflection;  // Defined below.
          +  // Typedef for backwards-compatibility.
          +  typedef google::protobuf::Reflection Reflection;
      
      The "typedef for backwards-compatibility" apparently lasted ten years
      until protobuf commit 6bbe197e9c1b6fc38cbdc45e3bf83fa7ced792a3
      ("Down-integrate from google3.", from August 2018) which finally removed
      the typedef:
      
          @@ -327,8 +344,6 @@ class LIBPROTOBUF_EXPORT Message : public MessageLite {
      
             // Introspection ---------------------------------------------------
      
          -  // Typedef for backwards-compatibility.
          -  typedef google::protobuf::Reflection Reflection;
      
      This commit updates the only use of this typedef (in the test suite) to
      directly refer to the replacement, google::protobuf::Reflection. This
      fixes the build failure in the test suite.
      7456d162
    • Robert Edmonds's avatar
      Merge pull request #368 from protobuf-c/edmonds/travis/protobuf-3.7.1 · 8a362db9
      Robert Edmonds authored
      .travis.yml: Bump protobuf version to 3.7.1, use new URL
      8a362db9
    • Robert Edmonds's avatar
  3. 14 Aug, 2018 14 commits
  4. 13 Aug, 2018 2 commits
  5. 11 Mar, 2018 1 commit
  6. 25 Sep, 2017 1 commit
  7. 14 Aug, 2017 1 commit
  8. 07 Aug, 2017 1 commit
    • Robert Edmonds's avatar
      Restore protobuf-2.x compatibility · 4302266b
      Robert Edmonds authored
      The change in commit 712154b9 ("Bump
      minimum required header version for proto3 syntax") uses functionality
      only exposed by protobuf-3.x, breaking the build when compiling against
      protobuf-2.x.
      
      Since we still want to support building against protobuf-2.x, this
      commit makes the proto3 syntax check in the file generator dependent on
      building against protobuf-3.x.
      4302266b
  9. 05 Aug, 2017 2 commits
  10. 31 Jul, 2017 1 commit
  11. 30 Jul, 2017 1 commit
    • Robert Edmonds's avatar
      Bump minimum required header version for proto3 syntax · 712154b9
      Robert Edmonds authored
      The changes in #274 (proto3: make strings default to "" instead of NULL)
      add a new symbol to the library and add an 'extern' declaration to the
      protobuf-c header file.
      
      Since the compiler may generate files that depend on that new
      'protobuf_c_empty_string' declaration in protobuf-c.h, we need to bump
      the min_header_version value that is written into generated header
      files. But since the 'protobuf_c_empty_string' symbol can only be
      referenced when generating proto3 syntax files, we only need to use the
      stricter min_header_version value when processing a proto3 file.
      712154b9
  12. 29 Jul, 2017 6 commits
  13. 12 Jun, 2017 1 commit
    • Paolo Borelli's avatar
      proto3: make strings default to "" instead of NULL · 2a46af42
      Paolo Borelli authored
      The spec talks about "empty string" and other languages like C#
      return a zero length string and not null.
      This is useful because when moving from proto2's "required string"
      to a proto3's plain string we will be guaranteed that we
      never get a null pointer.
      The tradeoff is adding a special case to the library but avoiding
      a lot of null checks in the calling code.
      The current code is already special casing "" in pack_string.
      2a46af42
  14. 10 Apr, 2017 4 commits