- 13 Jan, 2014 3 commits
-
-
Robert Edmonds authored
i'm confused as to why these fields exist, since the typical implementation of a "temporary alloc" would be something like alloca(), and alloca() is usually just inlined code that adjusts the stack pointer, which is not a function whose address could be taken. this breaks the API/ABI and will require a note in the ChangeLog. possibly we could revisit the idea of "temporary allocations" by using C99 variable length arrays. this would have the advantage of being standardized, unlike alloca().
-
Robert Edmonds authored
-
Robert Edmonds authored
-
- 11 Jan, 2014 9 commits
-
-
Robert Edmonds authored
-
Robert Edmonds authored
-
Robert Edmonds authored
-
Robert Edmonds authored
-
Robert Edmonds authored
-
Robert Edmonds authored
-
Robert Edmonds authored
this should silence Coverity #1153648, which complains because tmp.length_prefix_len is uninitialized for certain wire types when copied on line 2486: scanned_member_slabs[which_slab][in_slab_index++] = tmp;
-
Robert Edmonds authored
-
Robert Edmonds authored
dave's original style drives me crazy. reformat the C code in protobuf-c/ with "indent -kr -i8" and manually reflow for readability. try to fit most lines in 80 columns, but due to the lengthy type and function names in protobuf-c, enforcing an 80 column rule would result in a lot of cramped statements, so try to fit lines in up to 100 columns if it would improve readability. (e.g., one <=100 column line is probably better than 3-4 <=80 column lines.) ultimately i'd like to adopt most of the recommendations in the linux coding style: https://www.kernel.org/doc/Documentation/CodingStyle. this commit gets us most of the kernel indentation and comment coding style recommendations. later commits will tackle style recommendations that require more intrusive changes: breaking up large functions, replacing macros that affect control flow (e.g., DO_ALLOC). this will hopefully facilitate review and make the code base easier to maintain. i ran the old and new versions of protobuf-c.c through something like: gcc -S -D__PRETTY_FUNCTION__=0 -D__FILE__=0 -D__LINE__=0 -Wall -O0 \ -o protobuf-c.S -c protobuf-c.c and reviewed the diffs of the assembly output to spot any functions that changed, and went back to make sure that any differences were functionally equivalent.
-
- 10 Jan, 2014 7 commits
-
-
Robert Edmonds authored
-
Robert Edmonds authored
-
Robert Edmonds authored
-
Robert Edmonds authored
-
Robert Edmonds authored
-
Robert Edmonds authored
-
Robert Edmonds authored
-
- 21 Dec, 2013 2 commits
-
-
Ilya Lipnitskiy authored
(fixes #26)
-
Nick Galbreath authored
(fixes #106)
-
- 17 Dec, 2013 1 commit
-
-
Ilya Lipnitskiy authored
protoc-c/c_enum.cc: fix compiler warnings protoc-c/c_field.cc: fix compiler warnings
-
- 09 Dec, 2013 2 commits
-
-
Robert Edmonds authored
Signed-off-by: Dave Benson <lahiker42@gmail.com>
-
Robert Edmonds authored
-
- 04 Dec, 2013 1 commit
-
-
Ilya Lipnitskiy authored
better compatibility with 8- and 16-bit platforms (integrate fixes from #47)
-
- 02 Dec, 2013 1 commit
-
-
Ilya Lipnitskiy authored
-
- 28 Nov, 2013 1 commit
-
-
Ilya Lipnitskiy authored
protobuf_c_dispatch_close_fd() (fixes #82)
-
- 27 Nov, 2013 3 commits
-
-
Ilya Lipnitskiy authored
-
Ilya Lipnitskiy authored
check for server closures (responses) to not crash the server in case of a malformed message (related to #76)
-
Ilya Lipnitskiy authored
protobuf_c_message_check
-
- 23 Nov, 2013 4 commits
-
-
Ilya Lipnitskiy authored
leave a dangling pointer to the parsed submessage
-
Ilya Lipnitskiy authored
-
Robert Edmonds authored
-
Ilya Lipnitskiy authored
test_field_merge
-
- 22 Nov, 2013 1 commit
-
-
Ilya Lipnitskiy authored
of the same field on the wire (Fixes #91) t/generated-code2/test-generated-code2.c: add a test case for merging messages t/test-full.proto: expand message definitions to test for merging nested messages
-
- 21 Nov, 2013 2 commits
-
-
Robert Edmonds authored
-
Robert Edmonds authored
this simplifies the AC_C_BIGENDIAN invocation.
-
- 20 Nov, 2013 3 commits
-
-
Robert Edmonds authored
-
Robert Edmonds authored
-
Robert Edmonds authored
-