1. 03 Apr, 2014 9 commits
  2. 31 Mar, 2014 5 commits
    • Robert Edmonds's avatar
      .travis.yml: test on both gcc and clang · db49f8e8
      Robert Edmonds authored
      db49f8e8
    • Robert Edmonds's avatar
      53dcda6c
    • Robert Edmonds's avatar
      protobuf_c_message_unpack(): revert hash-based required field detection · d9a2f847
      Robert Edmonds authored
      Originally, someone complained about protobuf_c_message_unpack() using
      alloca() for the allocation of the temporary bitmap used to detect that
      all required fields were present in the unpacked message (Issue #60).
      Commit 248eae1d eliminated the use of alloca(), replacing the
      variable-length alloca()'d bitmap with a 16 byte stack-allocated bitmap,
      treating field numbers mod 128.
      
      Andrei Nigmatulin noted in PR #137 problems with this approach:
      
          Apparently 248eae1d has introduced a serious problem to protobuf-c
          decoder.
      
          Originally the function of required_fields_bitmap was to prevent
          decoder from returning incomplete messages. That means, each
          required field in the message either must have a default_value or be
          present in the protobuf stream. The purpose of this behaviour was to
          provide user with 100% complete ProtobufCMessage struct on return
          from protobuf_c_message_unpack(), which does not need to be checked
          for completeness just after. This is exactly how original protobuf
          C++ decoder behaves. The patch 248eae1d broke this functionality by
          hashing bits of required fields instead of storing them separately.
      
          Consider a protobuf message with 129 fields where the first and the
          last fields set as 'required'. In this case it is possible to trick
          decoder to return incomplete ProtobufCMessage struct with missing
          required fields by providing only one of the two fields in the
          source byte stream. This can be considered as a security issue as
          well because user's code do not expect incomplete messages with
          missing required fields out from protobuf_c_message_unpack(). Such a
          change could introduce undefined behaviour to user programs.
      
      This patch is based on Andrei's fix and restores the exact detection of
      missing required fields, but avoids doing a separate allocation for the
      required fields bitmap except for messages whose descriptors define a
      large number of fields. In the "typical" case where the message
      descriptor has <= 128 fields we can just use a 16 byte array allocated
      on the stack. (Note that the hash-based approach also used a 16 byte
      stack allocated array.)
      d9a2f847
    • Robert Edmonds's avatar
      ec961cb0
    • Andrei Nigmatulin's avatar
  3. 29 Mar, 2014 1 commit
  4. 28 Mar, 2014 3 commits
  5. 27 Mar, 2014 4 commits
  6. 26 Mar, 2014 5 commits
  7. 24 Mar, 2014 3 commits
    • Robert Edmonds's avatar
      configure.ac: check for a libprotoc header file · 16e3465d
      Robert Edmonds authored
      it's possible for the <google/protobuf/compiler/> header files to be
      shipped in a separate package (e.g., debian's libprotoc-dev). check for
      this at configure time rather than allowing the build process to fail.
      16e3465d
    • Oleg Efimov's avatar
      9c7f8ce7
    • Robert Edmonds's avatar
      protoc-c: preserve case in C enum value names (Issue #129) · d2658e25
      Robert Edmonds authored
      there is some confusion with regard to the use of lower case letters in
      enum values. take the following message definition:
      
          message LowerCase {
            enum CaseEnum {
              UPPER = 1;
              lower = 2;
            }
            optional CaseEnum value = 1 [default = lower];
          }
      
      this generates the following C enum:
      
          typedef enum _LowerCase__CaseEnum {
            LOWER_CASE__CASE_ENUM__UPPER = 1,
            LOWER_CASE__CASE_ENUM__lower = 2
              _PROTOBUF_C_FORCE_ENUM_TO_BE_INT_SIZE(LOWER_CASE__CASE_ENUM)
          } LowerCase__CaseEnum;
      
      note that the case of the enum value 'lower' was preserved in the C
      symbol name as 'LOWER_CASE__CASE_ENUM__lower', but that the _INIT macro
      references the same enum value with the (non-existent) C symbol name
      'LOWER_CASE__CASE_ENUM__LOWER':
      
          #define LOWER_CASE__INIT \
           { PROTOBUF_C_MESSAGE_INIT (&lower_case__descriptor) \
              , 0,LOWER_CASE__CASE_ENUM__LOWER }
      
      additionally, the ProtobufCEnumValue array generated also refers to the
      same enum value with the (non-existent) upper cased version:
      
          const ProtobufCEnumValue lower_case__case_enum__enum_values_by_number[2] =
          {
            { "UPPER", "LOWER_CASE__CASE_ENUM__UPPER", 1 },
            { "lower", "LOWER_CASE__CASE_ENUM__LOWER", 2 },
          };
      
      we should preserve the existing behavior of copying the case from the
      enum values in the message definition and fix up the places where the
      (non-existent) upper case version is used, rather than changing the enum
      definition itself to match the case used in the _INIT macro and
      enum_values_by_number array, because it's possible that there might be
      existing working code that uses enum values with lower case letters that
      would be affected by such a change.
      
      incidentally, google's C++ protobuf implementation preserves case in
      enum values. protoc --cpp_out generates the following enum declaration
      for the message descriptor above:
      
          enum LowerCase_CaseEnum {
            LowerCase_CaseEnum_UPPER = 1,
            LowerCase_CaseEnum_lower = 2
          };
      d2658e25
  8. 19 Mar, 2014 2 commits
  9. 14 Mar, 2014 3 commits
  10. 07 Mar, 2014 1 commit
  11. 17 Feb, 2014 2 commits
  12. 16 Feb, 2014 1 commit
    • Kevin Lyda's avatar
      Autoconf configuration for doxygen. · b9f94db3
      Kevin Lyda authored
      Still need to add the comments in the source code. Currently I've
      seeded it with the libprotobuf-c files.  I've configured it
      to make man pages and html pages.  Might not be ideal, but makes it easy
      for me to check things (html is nicer, but man pages are handier for
      remote servers).
      b9f94db3
  13. 10 Feb, 2014 1 commit