• Steven Cartmell's avatar
    fix: Break from loop on last iteration to resolve clang-tidy warning · f999d879
    Steven Cartmell authored
    The clang-tidy warning `clang-analyzer-cplusplus.Move` warns when a
    moved from object is deferenced. This is triggered in spdlog because
    clang-tidy fails to detect that the `logger:set_formatter` will only
    move the unique_ptr on the last iteration of the loop, assuming that
    `f->clone` may be called on it afterwards.
    
    To fix, add a break statement after moving the pointer (on the last
    iteration) to let clang-tidy know the logger pointer is not used after
    this point.
    f999d879
logger-inl.h 6.64 KB