Commit 3e4df86a authored by Trond H Emaus's avatar Trond H Emaus

create MSVC_OPTIONS list only if compiler is msvc

parent 7054cf7a
...@@ -28,10 +28,13 @@ endfunction() ...@@ -28,10 +28,13 @@ endfunction()
# Turn on warnings on the given target # Turn on warnings on the given target
function(spdlog_enable_warnings target_name) function(spdlog_enable_warnings target_name)
list(APPEND MSVC_OPTIONS "/W3") if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
if(MSVC_VERSION GREATER 1900) #Allow non fatal security wanrnings for msvc 2015 list(APPEND MSVC_OPTIONS "/W3")
list(APPEND MSVC_OPTIONS "/WX") if(MSVC_VERSION GREATER 1900) #Allow non fatal security wanrnings for msvc 2015
list(APPEND MSVC_OPTIONS "/WX")
endif()
endif() endif()
target_compile_options(${target_name} PRIVATE target_compile_options(${target_name} PRIVATE
$<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>: $<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>:
-Wall -Wextra -Wconversion -pedantic -Wfatal-errors> -Wall -Wextra -Wconversion -pedantic -Wfatal-errors>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment