1. 11 Jan, 2018 1 commit
  2. 03 Jan, 2018 4 commits
  3. 26 Dec, 2017 3 commits
    • Gabi Melman's avatar
      Merge pull request #596 from Broekman/master · a2890f27
      Gabi Melman authored
      Issue fix for spdlog #595. Conversion warning.
      a2890f27
    • Stefan Broekman's avatar
      Issue fix for spdlog #595. Conversion warning. · de4644b4
      Stefan Broekman authored
      See: https://github.com/gabime/spdlog/issues/595
      
      On line 85 in file sinks/wincolor_sink.h:
      back_color &= ~(FOREGROUND_RED | FOREGROUND_GREEN | FOREGROUND_BLUE |
      FOREGROUND_INTENSITY);
      
      'back_color' is of type 'WORD' (unsigned short) whereas a bitwise
      complement/NOT returns an int. This results in a conversion warning with
      -Wconversion enabled.
      
      85:20: warning: conversion to 'WORD {aka short unsigned int}' from 'int'
      may alter its value [-Wconversion] back_color &= ~(FOREGROUND_RED |
      FOREGROUND_GREEN | FOREGROUND_BLUE | FOREGROUND_INTENSITY);
      
      Possible solution:
      We know that the result of ~(FOREGROUND_RED | FOREGROUND_GREEN |
      FOREGROUND_BLUE | FOREGROUND_INTENSITY) is always within the limits of
      an unsigned short so a simple cast should suffice (correct me if I'm
      wrong):
      
      back_color &= static_cast<unsigned short>(~(FOREGROUND_RED |
      FOREGROUND_GREEN | FOREGROUND_BLUE | FOREGROUND_INTENSITY));
      de4644b4
    • Gabi Melman's avatar
      Update README.md · 03db1023
      Gabi Melman authored
      03db1023
  4. 24 Dec, 2017 1 commit
  5. 23 Dec, 2017 1 commit
  6. 22 Dec, 2017 11 commits
  7. 20 Dec, 2017 6 commits
  8. 19 Dec, 2017 4 commits
  9. 06 Dec, 2017 1 commit
  10. 05 Dec, 2017 1 commit
  11. 04 Dec, 2017 1 commit
  12. 03 Dec, 2017 2 commits
  13. 02 Dec, 2017 2 commits
  14. 01 Dec, 2017 2 commits