1. 22 Feb, 2018 2 commits
    • Gabi Melman's avatar
      Merge pull request #644 from grzadr/patch-1 · e64847bd
      Gabi Melman authored
      Fix indentation in tests/catch.hpp:2916
      e64847bd
    • grzadr's avatar
      Fix indentation in line 2916 · 8e861728
      grzadr authored
      Compiling with -Wmisleading-indentation triggers warning:
      /data/Git/spdlog/tests/catch.hpp: In member function ‘bool Catch::TestSpec::Filter::matches(const Catch::TestCaseInfo&) const’:
      /data/Git/spdlog/tests/catch.hpp:2913:17: warning: this ‘for’ clause does not guard... [-Wmisleading-indentation]
                       for( std::vector<Ptr<Pattern> >::const_iterator it = m_patterns.begin(), itEnd = m_patterns.end(); it != itEnd; ++it )
                       ^~~
      /data/Git/spdlog/tests/catch.hpp:2916:21: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘for’
                           return true;
                           ^~~~~~
      8e861728
  2. 11 Feb, 2018 3 commits
  3. 10 Feb, 2018 2 commits
    • Gabi Melman's avatar
      Merge pull request #634 from ColinDuquesnoy/patch-1 · 5eef243a
      Gabi Melman authored
      Fix compilation error with GCC 8
      5eef243a
    • Colin Duquesnoy's avatar
      Fix compilation error with GCC 8 · 11ee6834
      Colin Duquesnoy authored
      error: need 'typename' before 'std::conditional<std::is_same<char, char>::value, fmt::BasicMemoryWriter<char>, fmt::BasicMemoryWriter<wchar_t> >::type' because 'std::conditional<std::is_same<char, char>::value, fmt::BasicMemoryWriter<char>, fmt::BasicMemoryWriter<wchar_t> >' is a dependent scope
               std::conditional<std::is_same<filename_t::value_type, char>::value, fmt::MemoryWriter, fmt::WMemoryWriter>::type w;
      11ee6834
  4. 08 Feb, 2018 2 commits
  5. 05 Feb, 2018 1 commit
  6. 03 Feb, 2018 3 commits
  7. 27 Jan, 2018 1 commit
  8. 24 Jan, 2018 2 commits
  9. 18 Jan, 2018 4 commits
  10. 12 Jan, 2018 3 commits
  11. 11 Jan, 2018 3 commits
  12. 03 Jan, 2018 4 commits
  13. 26 Dec, 2017 3 commits
    • Gabi Melman's avatar
      Merge pull request #596 from Broekman/master · a2890f27
      Gabi Melman authored
      Issue fix for spdlog #595. Conversion warning.
      a2890f27
    • Stefan Broekman's avatar
      Issue fix for spdlog #595. Conversion warning. · de4644b4
      Stefan Broekman authored
      See: https://github.com/gabime/spdlog/issues/595
      
      On line 85 in file sinks/wincolor_sink.h:
      back_color &= ~(FOREGROUND_RED | FOREGROUND_GREEN | FOREGROUND_BLUE |
      FOREGROUND_INTENSITY);
      
      'back_color' is of type 'WORD' (unsigned short) whereas a bitwise
      complement/NOT returns an int. This results in a conversion warning with
      -Wconversion enabled.
      
      85:20: warning: conversion to 'WORD {aka short unsigned int}' from 'int'
      may alter its value [-Wconversion] back_color &= ~(FOREGROUND_RED |
      FOREGROUND_GREEN | FOREGROUND_BLUE | FOREGROUND_INTENSITY);
      
      Possible solution:
      We know that the result of ~(FOREGROUND_RED | FOREGROUND_GREEN |
      FOREGROUND_BLUE | FOREGROUND_INTENSITY) is always within the limits of
      an unsigned short so a simple cast should suffice (correct me if I'm
      wrong):
      
      back_color &= static_cast<unsigned short>(~(FOREGROUND_RED |
      FOREGROUND_GREEN | FOREGROUND_BLUE | FOREGROUND_INTENSITY));
      de4644b4
    • Gabi Melman's avatar
      Update README.md · 03db1023
      Gabi Melman authored
      03db1023
  14. 24 Dec, 2017 1 commit
  15. 23 Dec, 2017 1 commit
  16. 22 Dec, 2017 5 commits