• Cedric Roux's avatar
    hotfix: bad copy from userspace by ExpressMIMO2 kernel driver · 0b1a3ae4
    Cedric Roux authored
    The ExpressMIMO2 kernel driver did not use proper mechanisms
    to copy from user space.
    
    It is very surprising that it ever worked at all...
    
    This commit is a quick fix. It is not the end of the story
    and some more work may be needed if things don't work.
    
    The remaining issue is that we pass pointer addresses to the
    kernel as 32 bits values, but pointers are 64 bits values
    (on x86_64, our supported platform). Some checks have been
    put in place to detect if upper 32 bits of a pointer are
    not 0 and print a strong error message in case of problem,
    but no clean solution has been implemented.
    0b1a3ae4
updatefw.c 25 KB