1. 23 Feb, 2017 1 commit
    • Cedric Roux's avatar
      hotfix: pass "%s" to LOG_W to avoid compilation warnings · 0ae4512f
      Cedric Roux authored
      The warning was:
      
      ------------------------
      In file included from /roux/openairinterface5g/openair2/UTIL/LOG/log.h:306:0,
                       from /roux/openairinterface5g/openair1/PHY/defs.h:54,
                       from /roux/openairinterface5g/openair2/LAYER2/MAC/eNB_scheduler_ulsch.c:33:
      /roux/openairinterface5g/openair2/UTIL/LOG/log.h: In function 'printMeas':
      /roux/openairinterface5g/common/utils/T/T.h:94:26: warning: format not a string literal and no format arguments [-Wformat-security]
       #define T_ID(x) ((struct T_header *)(uintptr_t)(x))
                                ^
      /roux/openairinterface5g/common/utils/T/T.h:29:22: note: in definition of macro 'T_PUT_int'
           int T_PUT_var = (val); \
                            ^
      /roux/openairinterface5g/common/utils/T/T.h:269:7: note: in expansion of macro 'T_HEADER'
             T_HEADER(t); \
             ^
      /roux/openairinterface5g/common/utils/T/T.h:101:76: note: in expansion of macro 'T3'
               n18,n19,n20,n21,n22,n23,n24,n25,n26,n27,n28,n29,n30,n31,n32,n,...) T##n
                                                                                  ^
      /roux/openairinterface5g/common/utils/T/T.h:102:16: note: in expansion of macro 'TN'
       #define T(...) TN(__VA_ARGS__)
                      ^
      /roux/openairinterface5g/openair2/UTIL/LOG/log.h:308:28: note: in expansion of macro 'T'
       #    define LOG_W(c, x...) T(T_LEGACY_ ## c ## _WARNING, T_PRINTF(x))
                                  ^
      /roux/openairinterface5g/common/utils/T/T_IDs.h:71:30: note: in expansion of macro 'T_ID'
       #define T_LEGACY_PHY_WARNING T_ID(68)
                                    ^
      /roux/openairinterface5g/openair2/UTIL/LOG/log.h:308:30: note: in expansion of macro 'T_LEGACY_PHY_WARNING'
       #    define LOG_W(c, x...) T(T_LEGACY_ ## c ## _WARNING, T_PRINTF(x))
                                    ^
      /roux/openairinterface5g/openair2/UTIL/LOG/log.h:411:9: note: in expansion of macro 'LOG_W'
               LOG_W(PHY,txt2);
      ------------------------
      
      over and over.
      
      By replacing LOG_W(PHY,txt2) by LOG_W(PHY,"%s",txt2) all the warnings
      are removed.
      0ae4512f
  2. 20 Feb, 2017 4 commits
  3. 17 Feb, 2017 20 commits
  4. 16 Feb, 2017 13 commits
  5. 15 Feb, 2017 2 commits
    • Cedric Roux's avatar
      bugfix: fix PDCP inst · 7f9a7d74
      Cedric Roux authored
      This commit is a continuation of 614d6bbe2af5c34f3bace7a8cb5003f07a8931b2
      (ue_ip: use correct instance).
      
      Now in openair2/NETWORK_DRIVER/UE_IP/common.c the 'inst' is not
      forced to 1 anymore, we take the value 'pdcph_p->inst'.
      
      It turns out that 'pdcph_p->inst' is 0 instead of 1 when we
      run lte-softmodem as an UE.
      
      So let's modify PDCP to set 'inst' to 1 where it was set to 0 for
      the UE softmodem case, and skip the places where it is reset to 0,
      still for the UE softmodem case.
      
      This may break things, I am not sure.
      7f9a7d74
    • Cedric Roux's avatar
      bugfix: variable was on the stack · 816d96ba
      Cedric Roux authored
      Guess what happens when we return from the function...
      816d96ba