This commit continues to clean up the reminader
of the changed files in the merge req 1274.
The changes include log updates, comment removals,
etc.

This commit includes about 1/3 of the code clean up
in preparation for the merge to the OAI develop
branch. Several of the changes are white space changes,
removing of logs, comment removals, and updating any
changed code for our use-case to be clear for NSA mode.

Merge branch 'episys/david/sync_between_dl_tti_req_and_tx_data_req' into 'episys/mel/merge_develop_cfra_working_9_14_21'

Episys/david/sync between dl tti req and tx data req

See merge request aburger/openairinterface5g!60

Also, the ul_slot was not properly wrapping.
It was increased to a value greater than the
largest slot value.

But, we are not going to process the tx_request
unless we are waiting for the RAR OR if the RNTI
from the previous DCI matches.

In this commit, we create a new flag in the MAC
instance which is set to true if the recevied
DL DCI PDU's RNTI value matches the current UEs
RNTI value. If the RNTI value does not match,
then we should not process the recevied tx_request.
This check should only take place after the CFRA
procedure is complete.

Previously, we thought that filling the UCI ind
after we got the pdsch payload would stop the
 harq_pid from going inactive, but this was not
the case. The harq_pid is getting set to inactive
too early because of the sf_slot ahead value. The
fix for this will come in the next commit.

The harq_pid is set to inactive during the scheduling
of ACK/NACK, but this is happening before tx_req (PDSCH)
is recevied. We update the global harq_pid then use it
once we get the PDSCH PDU, then we set it to inactive.
Also, the global previously wasnt being set properly because
a memset was changing the def_dci_re15 struct. We now
memset after we update the harq_pid global.

In this commit, we introduced a new global to save
the harq_pid from the PDCCH that comes down in the
DCI message so that we can use the harq_pid in the
PDSCH. Now, the UCI ind will be filled after we
have recevied the PDSCH in the tx_request.

MR !1252 : Bugfix nr rlc w36
Fix a bug about segmentation present in both NR RLC AM and NR RLC UM.

MR !1253 : minor: T tracer: be more verbose for DLSCH DCI

MR !1254 : fix for pointa computation in sib1
Fix computation of pointA in SIB1

MR !1217 : fix-physim-run-script-on-cluster
oai-nr-dlsim may seem fine but in fact, test21 may or may not be executed. 
On some run example, we do not have finished message on nr-dlsim pod.

MR !1255 : Attempt to fix nr-dlsim Test 21 (4x4 MIMO, 2 Layers)

This commit is to handle multipe UE correctly.
Right now UE #1 and UE #2 can both ping google.

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>

MR !1245: [CI] Improve Iperf packet loss mismatch detection
-improve the Iperf packet loss detection and flagging when pl target (from xml) is below the test result

MR !1246: patch: remove call to end_configmodule
- full fix that set properly PARAMFLAG_NOFREE on relevant parameters

MR !1235: Nr msg4 retransmission
-Retransmission of msg4
-Some reworking in UE harq DLSCH processing

MR !1214: NR UE SA
-SIB1 detection part of initial sync at UE
-Removing a lot of hard-coding in SA procedures
-SSB start subcarrier from command line at UE

MR !1243: Nr skip mac pdu processing when nack
-Skipping processing DLSCH MAC PDU at OAI UE when NACK

MR !1229: fix(nr-ue): apply ip rules/route
-Also added 4G RF sim tests

Previously, the ue_id passed into the
init_pdcp() in  the proxy would be 41.
This is outside of the bounds of the
nas_sock_fd array and would cause a crash.
This was occuring because the node_number
in the NRUE starts at 2, not 1.

Merge branch 'episys/david/Adding_function_declaration_to_read_config_file' into 'episys/mel/merge_develop_cfra_working'

Added function declaration to read config file.

See merge request aburger/openairinterface5g!58

config files were also updated.

In this commit we have updated the NRUE
to properly get the RadioBearer info from
the gNB. Because NSA and SA mode both use
this information, we have updated the SA
function previously in place by changing
the name to allow both NSA and SA mode to
use. This commit also updated the NR/LTE UEs
configuration files to with the correct
proxy IP address.

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>

Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>