- 18 Mar, 2021 1 commit
-
-
David Kim authored
-
- 15 Mar, 2021 1 commit
-
-
David Kim authored
-
- 14 Mar, 2021 5 commits
-
-
Michael Cook authored
-
Michael Cook authored
assert() statements were enabled for C code but disabled for C++ code. With this commit, assert() is enabled for both C and C++ for RelWithDebInfo builds.
-
Michael Cook authored
-
Michael Cook authored
-
Michael Cook authored
-
- 13 Mar, 2021 6 commits
-
-
David Kim authored
-
Michael Cook authored
-
Michael Cook authored
-
Michael Cook authored
-
Michael Cook authored
With a small number of runs with 16 UEs, I've seen this AssertFatal fail twice. There are many other places in the code that simply skip over ulsch[i] values that are NULL.
-
David Kim authored
-
- 12 Mar, 2021 2 commits
-
-
Melissa Elkadi authored
-
David Kim authored
-
- 11 Mar, 2021 2 commits
-
-
Raphael Defosseux authored
CI: try to optimize the file system usage when building in the CI VM env. Increased the VM memory of one to allow linking Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
-
Melissa Elkadi authored
-
- 10 Mar, 2021 1 commit
-
-
Melissa Elkadi authored
Merge branch 'episys-merge' of https://gitlab.eurecom.fr/oai/openairinterface5g into eurecom-episys-merge
-
- 07 Mar, 2021 1 commit
-
-
Raphael Defosseux authored
CI: removing 1 VM in the pipeline See merge request oai/openairinterface5g!1078
-
- 06 Mar, 2021 2 commits
-
-
Melissa Elkadi authored
Commented out an abort(); used for debugging. An incoming merge request will properly handle the issue of multiple CQIs.
-
Raphael Defosseux authored
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
-
- 05 Mar, 2021 3 commits
-
-
Raphael Defosseux authored
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
-
Raphael Defosseux authored
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
-
Raphael Defosseux authored
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
-
- 04 Mar, 2021 1 commit
-
-
Melissa Elkadi authored
-
- 03 Mar, 2021 1 commit
-
-
Melissa authored
-
- 02 Mar, 2021 2 commits
-
-
Melissa Elkadi authored
These cppcheck errors are occuring in code that is untouched by this merge request.
-
Florian Kaltenberger authored
-
- 01 Mar, 2021 5 commits
-
-
Melissa Elkadi authored
-
Melissa Elkadi authored
-
Remi Hardy authored
MR1029 : Benetel driver update This MR fixes an issue with the driver for the 4G Benetel RRUs. Power levels on the 5G side were adapted to avoid saturation of the signals. 5G performance is now the same as with USRP. Support for 2 antennas for both 4G and 5G was added MR1062 : fixing the RE offset for each Rx antenna in pusch channel estimation
-
Michael Cook authored
To enable -fsanitize=address option to the compiler which enables run-time checks for some kinds of memory mismanagement.
-
Michael Cook authored
-
- 28 Feb, 2021 3 commits
-
-
Michael Cook authored
This code allocates memory from the heap: ``` static void *UE_phy_stub_standalone_pnf_task(void *arg) { ... UL_INFO->crc_ind.crc_indication_body.crc_pdu_list = calloc(NB_UE_INST, sizeof(nfapi_crc_indication_pdu_t)); ``` I see NB_UE_INST==1. Then this code: ``` void fill_crc_indication_UE_MAC(int Mod_id, int frame, int subframe, UL_IND_t *UL_INFO, uint8_t crc_flag, int index, uint16_t rnti, nfapi_ul_config_request_t *ul_config_req) { ... nfapi_crc_indication_pdu_t *pdu = &UL_INFO->crc_ind.crc_indication_body .crc_pdu_list[UL_INFO->crc_ind.crc_indication_body.number_of_crcs]; ``` used .number_of_crcs to index into .crc_pdu_list without first checking if .number_of_crcs is in range. When run with multiple UEs, sometimes .number_of_crcs==1 and then -fsanitize=address complains. Change is to use NUMBER_OF_UE_MAX instead of NB_UE_INST. With this change, -fsanitize=address stopping complaining.
-
Michael Cook authored
-fsanitize=address complained about this code.
-
Michael Cook authored
-fsanitize=address detected that we were trying to access bytes past the end of a block of malloc'ed memory. Specifically, in this code: ``` } else if (ENB_NAS_USE_TUN) { if( LOG_DEBUGFLAG(DEBUG_PDCP) ) log_dump(PDCP, pdcpData, sizeToWrite, LOG_DUMP_CHAR,"PDCP output to be sent to TUN interface: \n"); ret = write(nas_sock_fd[0], pdcpData, sizeToWrite); ``` -fsanitize=address said: ``` ==80==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x61100004ffdc at pc 0x7f57c5f576a5 bp 0x7f57bb53c240 sp 0x7f57bb53b9e8 READ of size 108 at 0x61100004ffdc thread T7 0x61100004ffdc is located 0 bytes to the right of 220-byte region [0x61100004ff00,0x61100004ffdc) ``` So, the code was trying to access the first byte after a block of heap memory. sizeToWrite was calculated like this: ``` int sizeToWrite= sizeof (pdcp_data_ind_header_t) + pdcpHead->data_size; ``` There were a few other similar invocations of write() in the same function used the wrong size. That sizeToWrite calculation should be used only when the header is being sent, too, which happens in only one place in this function. With this commit, our tests pass and -fsanitize=address is happy.
-
- 27 Feb, 2021 4 commits
-
-
Michael Cook authored
Found by -fsanitize=address
-
Michael Cook authored
The global mbms_rab_id was defined as `uint16_t` in eNB_scheduler_mch.c but `int` in other places. So, code that wrotes this global would clobber the two bytes that follow the variable in memory. Found by `-fsanitize=address`.
-
Michael Cook authored
Found by `-fsanitize=address`.
-
Michael Cook authored
In phy_free_lte_eNB in lte_init.c, the lte-uesoftmodem would crash during shutdown because it was dereferencing null pointers. This commit adds checks to avoid that.
-