chore(ci): switching to U20 for published images

* Also prepared the documentation for `v1.5.1` release
* Also fixed the CI clang-format check
* A little compilation error fix for Ubuntu22

CHANGELOG.md

 # RELEASE NOTES: #
 
+## v1.5.1 -- May 2023 ##
+
+* Fix Service Request handling (Service Type: Signalling)
+* Fix N2 handover
+* Support usage of SUPI-type IMSI
+* Fix mapping between RAN UE NGAP ID and UE context
+* Fix SBI port for UDM in case of FQDN resolution
+* Fix TMSI handling
+* Fix PDU Session Ressource Release Response message
+* Fix issue for decoding MSIN with an odd number of digits
+* Fix usage of lower-case for DNN value (case insensitive)
+* Fix: NSSF port number was not read from config file
+* Code Refactoring for:
+  * NAS layer
+  * Registration Complete Message
+  * UE context refactor
+  * Logging mechanism (runtime log level selection)
+  * Installation / build scripts
+  * Continuous Integration scripts
+* Published image on Docker-Hub is using now Ubuntu-20 as base image
+  * We will soon obsolete the build system for Ubuntu18.04
+
 ## v1.5.0 -- January 2023 ##
 
 * Minimal fix for Decoding RegistrationRequest from COTS UE

CONTRIBUTING.md

@@ -15,6 +15,19 @@ Please refer to the steps described on our website: [How to contribute to OAI](h
       * The Continuous Integration will reject your pull request.
    - All pull requests SHALL have **`develop`** branch as target branch.
 
+## Synchronizing GIT sub-modules ##
+
+We are using nested GIT submodules. To synchronize them, the 2 most important commands to know are :
+
+1. `git submodule deinit --force .`
+2. `git submodule update --init --recursive`
+
+If you have non-tracked files or modified files within git submodules, these commands may not work.
+
+Use the `--verbose` option to see the execution of each command.
+
+If the synchronization fails, you may need to go into the path of the failing git-submodule(s) and clean the workspace from non-tracked/modified files.
+
 ## Coding Styles ##
 
 We are using `clang-format` as formatting tool on the C/C++ code.

ci-scripts/Jenkinsfile-GitLab-Docker

@@ -212,7 +212,7 @@ pipeline {
               script {
                 sh "sudo podman image prune --force"
                 sh "rm -Rf ./etc-pki-entitlement ./rhsm-conf ./rhsm-ca"
-                stash includes: 'archives/amf_podman_image_build.log', name: 'podmanBuildLog'
+                stash allowEmpty: true, includes: 'archives/amf_podman_image_build.log', name: 'podmanBuildLog'
               }
             }
           }
@@ -247,7 +247,7 @@ pipeline {
             }
             cleanup {
               script {
-                stash includes: 'archives/cppcheck*.*', name: 'cppcheckLogs'
+                stash allowEmpty: true, includes: 'archives/cppcheck*.*', name: 'cppcheckLogs'
                 // no need to keep the cppcheck container
                 sh 'docker rm -f amf-ci-cppcheck || true'
                 sh 'docker rmi amf-cppcheck:test || true'
@@ -284,7 +284,7 @@ pipeline {
           post {
             cleanup {
               script {
-                stash includes: 'src/oai_rules_result*.txt', name: 'formatCheckLogs'
+                stash allowEmpty: true, includes: 'src/oai_rules_result*.txt, archives/clang_format_install.log', name: 'formatCheckLogs'
                 sh 'docker rm -f amf-ci-clang-format || true'
                 sh 'docker rmi amf-clang-format-check:test || true'
               }

common @ b9ca1e67

-Subproject commit 99747a00750c678b24b72a2c377ae65086910077
+Subproject commit b9ca1e67d3e4b4fee5075d90e98015698ab1f0a1

ci-scripts/generateHtmlReport.py

@@ -58,7 +58,7 @@ class HtmlReport():
         with open(os.path.join(cwd, REPORT_NAME), 'w') as wfile:
             wfile.write(generate_header(args))
             wfile.write(generate_git_info(args))
-            wfile.write(build_summary(args, 'amf', '18', '8'))
+            wfile.write(build_summary(args, 'amf', '20', '8'))
             wfile.write(coding_formatting_log_check(args))
             wfile.write(analyze_sca_log_check())
             wfile.write(generate_footer())

ci-scripts/openshift/oai-amf-bc.yaml

-#/*
-# * Licensed to the OpenAirInterface (OAI) Software Alliance under one or more
-# * contributor license agreements.  See the NOTICE file distributed with
-# * this work for additional information regarding copyright ownership.
-# * The OpenAirInterface Software Alliance licenses this file to You under
-# * the OAI Public License, Version 1.1  (the "License"); you may not use this file
-# * except in compliance with the License.
-# * You may obtain a copy of the License at
-# *
-# *      http://www.openairinterface.org/?page_id=698
-# *
-# * Unless required by applicable law or agreed to in writing, software
-# * distributed under the License is distributed on an "AS IS" BASIS,
-# * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# * See the License for the specific language governing permissions and
-# * limitations under the License.
-# *-------------------------------------------------------------------------------
-# * For more information about the OpenAirInterface (OAI) Software Alliance:
-# *      contact@openairinterface.org
-# */
-#---------------------------------------------------------------------
-#
----
-kind: BuildConfig
-apiVersion: build.openshift.io/v1
-metadata:
-    name: "oai-amf"
-    namespace: oaicicd-core
-spec:
-    runPolicy: "Serial"
-    source:
-        type: "Binary"
-        secrets:
-          - secret:
-              name: etc-pki-entitlement
-            destinationDir: etc-pki-entitlement
-        configMaps:
-          - configMap:
-              name: rhsm-conf
-            destinationDir: rhsm-conf
-          - configMap:
-              name: rhsm-ca
-            destinationDir: rhsm-ca
-    strategy:
-        dockerStrategy:
-            dockerfilePath: "docker/Dockerfile.amf.rhel8"
-    output:
-        to:
-            kind: "ImageStreamTag"
-            name: "oai-amf:develop"

ci-scripts/openshift/oai-amf-is.yaml

-#/*
-# * Licensed to the OpenAirInterface (OAI) Software Alliance under one or more
-# * contributor license agreements.  See the NOTICE file distributed with
-# * this work for additional information regarding copyright ownership.
-# * The OpenAirInterface Software Alliance licenses this file to You under
-# * the OAI Public License, Version 1.1  (the "License"); you may not use this file
-# * except in compliance with the License.
-# * You may obtain a copy of the License at
-# *
-# *      http://www.openairinterface.org/?page_id=698
-# *
-# * Unless required by applicable law or agreed to in writing, software
-# * distributed under the License is distributed on an "AS IS" BASIS,
-# * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# * See the License for the specific language governing permissions and
-# * limitations under the License.
-# *-------------------------------------------------------------------------------
-# * For more information about the OpenAirInterface (OAI) Software Alliance:
-# *      contact@openairinterface.org
-# */
-#---------------------------------------------------------------------
-#
-apiVersion: image.openshift.io/v1
-kind: ImageStream
-metadata:
-    name: oai-amf
-    namespace: oaicicd-core
-spec:
-  lookupPolicy:
-    local: true
-status:
-    tag: develop

docker/Dockerfile.amf.ubuntu

@@ -30,7 +30,7 @@
 #---------------------------------------------------------------------
 # BASE IMAGE
 #---------------------------------------------------------------------
-ARG BASE_IMAGE=ubuntu:bionic
+ARG BASE_IMAGE=ubuntu:focal
 FROM $BASE_IMAGE as oai-amf-base
 
 ENV DEBIAN_FRONTEND=noninteractive

src/contexts/ue_context.hpp

@@ -25,6 +25,8 @@
 #include <stdint.h>
 
 #include <map>
+#include <memory>
+#include <mutex>
 #include <shared_mutex>
 
 #include "NgapIEsStruct.hpp"

src/ngap/ngapMsgs/NgapMessage.cpp

@@ -41,7 +41,6 @@ NgapMessage::NgapMessage() {
 
 //------------------------------------------------------------------------------
 NgapMessage::~NgapMessage() {
-
   ASN_STRUCT_FREE(asn_DEF_Ngap_NGAP_PDU, ngapPdu);
   Logger::ngap().debug("Free NGAP Message PDU");
 }