Skip to content

O
OpenXG-RAN
Commit 679816c3 authored by Melissa Elkadi's avatar Melissa Elkadi
Browse files
Options

Added comment around asn1cCalloc memory leak

parent 39d9febc
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 1 deletion
openair2/RRC/LTE/MESSAGES/asn1_msg.c
View file @ 679816c3
...@@ -4293,8 +4293,9 @@ ssize_t do_nrMeasurementReport(uint8_t *buffer, ...@@ -4293,8 +4293,9 @@ ssize_t do_nrMeasurementReport(uint8_t *buffer,
LTE_MeasResultListEUTRA_t *measResultListEUTRA2=&measResultNeighCells->choice.measResultListEUTRA; LTE_MeasResultListEUTRA_t *measResultListEUTRA2=&measResultNeighCells->choice.measResultListEUTRA;
asn1cSequenceAdd(measResultListEUTRA2->list, struct LTE_MeasResultEUTRA, measresulteutra_list); asn1cSequenceAdd(measResultListEUTRA2->list, struct LTE_MeasResultEUTRA, measresulteutra_list);
measresulteutra_list->physCellId = phy_id; measresulteutra_list->physCellId = phy_id;
/* TODO: This asn1cCalloc leaks memory but also masks a bug.
If we delete this asn1cCalloc statement, eNB will crash in NSA mode. */
asn1cCalloc(measresulteutra_list->cgi_Info, measresult_cgi2); asn1cCalloc(measresulteutra_list->cgi_Info, measresult_cgi2);
memset(measresult_cgi2, 0, sizeof(LTE_CellGlobalIdEUTRA_t));
struct LTE_MeasResultEUTRA__measResult* measResult= &measresulteutra_list->measResult; struct LTE_MeasResultEUTRA__measResult* measResult= &measresulteutra_list->measResult;
asn1cCallocOne(measResult->rsrpResult, rsrp_tar); asn1cCallocOne(measResult->rsrpResult, rsrp_tar);
asn1cCallocOne(measResult->rsrqResult, rsrq_tar); asn1cCallocOne(measResult->rsrqResult, rsrq_tar);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment