tackle code review remarks

executables/nr-softmodem-common.h

@@ -51,7 +51,6 @@
 #define CONFIG_HLP_UEFO          "set UE to enable estimation and compensation of frequency offset\n"
 #define CONFIG_HLP_DUMPFRAME     "dump UE received frame to rxsig_frame0.dat and exit\n"
 #define CONFIG_HLP_DLSHIFT       "dynamic shift for LLR compuation for TM3/4 (default 0)\n"
-#define CONFIG_HLP_UELOOP        "get softmodem (UE) to loop through memory instead of acquiring from HW\n"
 #define CONFIG_HLP_PHYTST        "test UE phy layer, mac disabled\n"
 #define CONFIG_HLP_DORA          "test gNB  and UE with RA procedures\n"
 #define CONFIG_HLP_DMAMAP        "sets flag for improved EXMIMO UE performance\n"

executables/nr-ue.c

@@ -655,14 +655,6 @@ static void UE_synch(void *arg) {
               openair0_cfg[UE->rf_map.card].tx_freq[0]);
 
         UE->rfdevice.trx_set_freq_func(&UE->rfdevice,&openair0_cfg[0],0);
-        //UE->rfdevice.trx_set_gains_func(&openair0,&openair0_cfg[0]);
-        //UE->rfdevice.trx_stop_func(&UE->rfdevice);
-        // sleep(1);
-        /*if (UE->rfdevice.trx_start_func(&UE->rfdevice) != 0 ) {
-          LOG_E(HW,"Could not start the device\n");
-          oai_exit=1;
-          }*/
-        
         if (UE->UE_scan_carrier == 1) {
           UE->UE_scan_carrier = 0;
         } else {
@@ -815,9 +807,9 @@ void processSlotRX(void *arg) {
 
 void dummyWrite(PHY_VARS_NR_UE *UE,openair0_timestamp timestamp, int writeBlockSize) {
   void *dummy_tx[UE->frame_parms.nb_antennas_tx];
-
+  int16_t dummy_tx_data[UE->frame_parms.nb_antennas_tx][2*writeBlockSize]; // 2 because the function we call use pairs of int16_t implicitly as complex numbers
   for (int i=0; i<UE->frame_parms.nb_antennas_tx; i++)
-    dummy_tx[i]=malloc16_clear(writeBlockSize*4);
+    dummy_tx[i]=dummy_tx_data[i];
 
   AssertFatal( writeBlockSize ==
                UE->rfdevice.trx_write_func(&UE->rfdevice,
@@ -827,8 +819,6 @@ void dummyWrite(PHY_VARS_NR_UE *UE,openair0_timestamp timestamp, int writeBlockS
                UE->frame_parms.nb_antennas_tx,
                4),"");
 
-  for (int i=0; i<UE->frame_parms.nb_antennas_tx; i++)
-    free(dummy_tx[i]);
 }
 
 void readFrame(PHY_VARS_NR_UE *UE,  openair0_timestamp *timestamp, bool toTrash) {

executables/softmodem-common.h

@@ -53,7 +53,6 @@ extern "C"
 
 
 #define CONFIG_HLP_DUMPFRAME     "dump UE received frame to rxsig_frame0.dat and exit\n"
-#define CONFIG_HLP_UELOOP        "get softmodem (UE) to loop through memory instead of acquiring from HW\n"
 #define CONFIG_HLP_PHYTST        "test UE phy layer, mac disabled\n"
 #define CONFIG_HLP_DORA          "test gNB  and UE with RA procedures\n"
 #define CONFIG_HLP_SA            "run gNB in standalone mode\n"

targets/RT/USER/lte-ru.c

@@ -835,8 +835,9 @@ void tx_rf(RU_t *ru,
     // in case of rfsim, we always enable tx because we need to feed rx of the opposite side
     // we write 1 single I/Q sample to trigger Rx (rfsim will fill gaps with 0 I/Q)
     void *dummy_tx[ru->frame_parms->nb_antennas_tx];
+    int16_t dummy_tx_data[ru->frame_parms->nb_antennas_tx][2]; // 2 because the function we call use pairs of int16_t implicitly as complex numbers
     for (int i=0; i<ru->frame_parms->nb_antennas_tx; i++)
-      dummy_tx[i]=malloc16_clear(4);
+      dummy_tx[i]= dummy_tx_data[i];
     
     AssertFatal( 1 ==
                  ru->rfdevice.trx_write_func(&ru->rfdevice,
@@ -846,8 +847,6 @@ void tx_rf(RU_t *ru,
                                              ru->frame_parms->nb_antennas_tx,
                                              4),"");
     
-    for (int i=0; i<ru->frame_parms->nb_antennas_tx; i++)
-      free(dummy_tx[i]);
   }
 }