1. 06 Mar, 2019 4 commits
    • Robert Schmidt's avatar
      Correctly link lte-uesoftmodem(-nos1) (hack) · bbedd315
      Robert Schmidt authored
      Although not used in the UE, we currently need to link the F1 library into it.
      This is because we do not define ASN_DISABLE_OER_SUPPORT (otherwise, F1 has
      compilation problems). In this case, some functions are apparently not
      correctly defined, giving linker errors in the UE. Linking F1 in solves the
      problem.
      
      This is a hack. It would be better to be able to define ASN_DISABLE_OER_SUPPORT
      and have no compilation errors or compile everything with
      ASN_DISABLE_OER_SUPPORT except F1. I did not do this because I did not find
      another way than add target_compile_definitions() to every target except F1
      which adds many lines just so that one target (F1 ASN.1) compiles correctly (in
      other words, F1 needs to be fixed).
      bbedd315
    • Robert Schmidt's avatar
      275b559f
    • Robert Schmidt's avatar
      Handle cppcheck errors in ASYNC_IF · 7a7c2afa
      Robert Schmidt authored
      7a7c2afa
    • Robert Schmidt's avatar
      Fix cppcheck issues in PROTO_AGENT · 66d4c4e9
      Robert Schmidt authored
      66d4c4e9
  2. 05 Mar, 2019 2 commits
  3. 04 Mar, 2019 2 commits
  4. 01 Mar, 2019 2 commits
  5. 28 Feb, 2019 5 commits
  6. 27 Feb, 2019 3 commits
    • Robert Schmidt's avatar
      1e3d0c9a
    • Cedric Roux's avatar
      bugfix: fix PDCP sequence management (plus some cleanup) · e3782b5c
      Cedric Roux authored
      With the introduction of X2AP into develop, the UEs now have to regularly
      send measurement reports.
      
      In the logs of the eNB, we see:
      
      [OSA]   Mismatch found in integrity for algorithm 2,
              got e0.a0.c2.66, expecting a5.9c.cb.57
      [PDCP]   [OSA][RB 1] eNB failed to validate MAC-I of incoming PDU
      
      This is a bug in the PDCP layer that uses wrong parameters to compute the
      integrity.
      
      This commit fixes this bug.
      
      The function pdcp_is_rx_seq_number_valid was removed. Its processing
      has been directly integrated into the function pdcp_data_ind.
      
      The function pdcp_mark_current_pdu_as_received is not called anymore.
      Its processing was not used later on, so as of today, not calling it does
      not introduce any functional change.
      
      The function pdcp_validate_security takes now as parameters both
      SN and HFN. Same for the function pdcp_get_next_count_rx.
      
      Useless constants PDCP_SN_5BIT, PDCP_SN_7BIT and PDCP_SN_12BIT have been
      removed.
      
      The compilation option ENABLE_SECURITY has been removed. It's now always
      on. (This may impact some use cases.)
      
      The PDCP for DRB using RLC AM is not correct. It was not correct before
      this commit (apart from the integrity bug). We should deal with a list
      of PDUs and transmit packets to upper layers as detailed in the specs.
      Today we transmit the PDU as soon as we get it. We don't care about
      duplicates, in-order delivery, timeouts.
      
      Also, we don't deal with "PDCP re-establishment". Not sure how that impacts
      the software.
      
      And, last but not least, there is still no ROHC.
      e3782b5c
    • Raphael Defosseux's avatar
  7. 26 Feb, 2019 2 commits
  8. 25 Feb, 2019 7 commits
  9. 22 Feb, 2019 13 commits