- 19 May, 2017 10 commits
-
-
Cedric Roux authored
-
Cedric Roux authored
-
Cedric Roux authored
-
Cedric Roux authored
-
Cedric Roux authored
Problems reported by Jorge Muñoz Castañer <jorgem@gti.uvigo.es>. - use Rel14 binaries (those are produced by default) - let -x option work to have graphical output - fix VCD missing 'echo'
-
Cedric Roux authored
we can compute CCE_max_used_index out of the loop.
-
Cedric Roux authored
get_nCCE returns the number of available CCEs. We can put the CCEs numbers [ 0 .. get_nCCE-1 ], so we need to use <, not <=.
-
Cedric Roux authored
-
echigoya authored
-
Tomohiro authored
-
- 18 May, 2017 7 commits
-
-
Cedric Roux authored
force j to -1, there is a compilation warning with the T tracer (variable may be used uninitialized)
-
Cedric Roux authored
It seems that ciphering_algorithm is "unsigned int" in RRC Rel10 and "unsigned long" in RRC Rel14 (as processed by asn1c) Let's force it to unsigned long in the log to avoid compilation-time warnings.
-
Cedric Roux authored
those popped up thanks to previous commit
-
Cedric Roux authored
Seems like this commit got lost at some point. Here was the message: ----------------------------------------------------------------------------- Author: Cedric Roux <cedric.roux@eurecom.fr> Date: Tue Jan 10 14:21:02 2017 +0100 add format indicator to get LOG_X warnings The LOG_X macros emit a lot of warnings when compiling with the T because they call the function logRecord (or logRecord_mt) which has not been "marked" as calling printf, so gcc won't emit typical printf warnings. With the T, they directly translate to sprintf, so those warnings pop up, much more verbose due to several macro expansions. Let's make them pop up all the time so it's easier to fix them. -----------------------------------------------------------------------------
-
Cedric Roux authored
-
Cedric Roux authored
-
Cedric Roux authored
- print current working directory - print git version (if available) - print security keys this last one is a security breach, but as of today it's not a problem
-
- 17 May, 2017 1 commit
-
-
Cedric Roux authored
-
- 15 May, 2017 9 commits
-
-
Cedric Roux authored
develop_integration_w19 into develop Summary of changes: - bug fixes: * RLC AM fixes * UE TDD fixes * Fujitsu bug fixes (TDD also) * mobipass fixes (bad management of carriers, softmodem was failing with more than one CC) * compilation warnings removal - PUCCH format 3 preliminary support (work from Fujitsu) - build fixes: do not include shared library in main executable (work from Nokia) express MIMO2 needs some more work here See merge request !184
-
Cedric Roux authored
-
Cedric Roux authored
No need for this special case. Plus, it fails with the work from Nokia on compilation cleanup.
-
Cedric Roux authored
-
Cedric Roux authored
-
Cedric Roux authored
-
Cedric Roux authored
-
Cedric Roux authored
There is now the function copy_harq_proc_struct and some procedures for the UE have changed, which makes necessary to have UE->dlsch valid for both subframes (odd and even). We increase memory usage, maybe it's not the correct solution. To be kept in mind if something goes wrong at some point.
-
Cedric Roux authored
Merge remote-tracking branch 'origin/bugfix_multiple_carriers_mobipass' into develop_integration_w19
-
- 13 May, 2017 1 commit
-
-
Cedric Roux authored
We have to test that all active CCs of a given UE exist in the PHY layer. Maybe not the end of the story...
-
- 12 May, 2017 12 commits
-
-
Cedric Roux authored
-
Cedric Roux authored
-
Cedric Roux authored
-
Cedric Roux authored
-
Cedric Roux authored
-
Tien-Thinh Nguyen authored
fix the errors related to multiple carriers (for a given UE considering only the CCs which this UE belongs to)
-
gabrielC authored
```------------------------------------------------------- bug 37 Ttile: Sending side is as follows. rar[3] = (((mcs&0x7)<<5)) | ((TPC&7)<<2) | ((ULdelay&1)<<1) | (cqireq&1); So, 2 bit shift looks correct. Bug Location: ulsch->harq_processes[harq_pid]->TPC = (rar[3]>>3)&7;//rar->TPC; ``` -------------------------------------------------------
-
gabrielC authored
```------------------------------------------------------- bug 29 Ttile: FDD should be TDD. Bug Location: switch (oai_emulation.info.frame_type[0]) { case FDD: frame_type = "FDD"; break; case TDD: frame_type = "FDD"; break; } ``` -------------------------------------------------------
-
gabrielC authored
```------------------------------------------------------- bug 26 Ttile: g_buffer has only 32 index, but he/she tries to zero clear 1024 index. Bug Location: static uint8_t g_buffer[32]; : memset (g_buffer, 0, 1024); Note: Detected by CppCheck ``` -------------------------------------------------------
-
Cedric Roux authored
```------------------------------------------------------- bug 24 Ttile: The last line "multicast_group = multicast_group" is hard to understand. The local variable should be different name than the global variable. Bug Location: const char *multicast_group_list[MULTICAST_LINK_NUM_GROUPS] = { "239.0.0.161", "239.0.0.162", "239.0.0.163", "239.0.0.164" }; : : void multicast_link_start(void (*rx_handlerP) (unsigned int, char *), unsigned char multicast_group, char *multicast_ifname) { rx_handler = rx_handlerP; multicast_group = multicast_group; Note: Detected by CppCheck ``` -------------------------------------------------------
-
gabrielC authored
Note: not sure that the code is correct, to be checked (Cédric Roux). ---------------------------------------------------------- bug 22 Ttile: (subframe!=2)||(subframe!=7) is always TRUE. This coding is really intended? Operator || should be && instead? Bug Location: ((frame_parms->frame_type==TDD)&&(frame_parms->tdd_config==1)&&((subframe!=2)||(subframe!=7)))) { Note: Detected by CppCheck ----------------------------------------------------------
-
gabrielC authored
Note: this fix does not solve the issue with how this buffer is used in this function, but I'm not sure this code is used at all (Cédric Roux). ---------------------------------------------------------- bug 21 Ttile: PAYLOAD_MAX=1500, so this coding results in index overflow. Additionally, operator "!=" just compairs something, this coding is meaningless. Bug Location: buffer[PAYLOAD_MAX] != '\0'; Note: Detected by CppCheck ----------------------------------------------------------
-