Minor fixes after code review

openair2/LAYER2/NR_MAC_UE/config_ue.c

@@ -42,14 +42,14 @@ void set_tdd_config_nr_ue(fapi_nr_config_request_t *cfg,
                           int mu,
                           NR_TDD_UL_DL_ConfigCommon_t *tdd_config) {
 
-  int nrofDownlinkSlots   = tdd_config->pattern1.nrofDownlinkSlots;
-  int nrofDownlinkSymbols = tdd_config->pattern1.nrofDownlinkSymbols;
-  int nrofUplinkSlots     = tdd_config->pattern1.nrofUplinkSlots;
-  int nrofUplinkSymbols   = tdd_config->pattern1.nrofUplinkSymbols;
+  const int nrofDownlinkSlots   = tdd_config->pattern1.nrofDownlinkSlots;
+  const int nrofDownlinkSymbols = tdd_config->pattern1.nrofDownlinkSymbols;
+  const int nrofUplinkSlots     = tdd_config->pattern1.nrofUplinkSlots;
+  const int nrofUplinkSymbols   = tdd_config->pattern1.nrofUplinkSymbols;
   int slot_number = 0;
-  int nb_periods_per_frame = get_nb_periods_per_frame(tdd_config->pattern1.dl_UL_TransmissionPeriodicity);
-  int nb_slots_to_set = TDD_CONFIG_NB_FRAMES*(1<<mu)*NR_NUMBER_OF_SUBFRAMES_PER_FRAME;
-  int nb_slots_per_period = ((1<<mu) * NR_NUMBER_OF_SUBFRAMES_PER_FRAME)/nb_periods_per_frame;
+  const int nb_periods_per_frame = get_nb_periods_per_frame(tdd_config->pattern1.dl_UL_TransmissionPeriodicity);
+  const int nb_slots_to_set = TDD_CONFIG_NB_FRAMES*(1<<mu)*NR_NUMBER_OF_SUBFRAMES_PER_FRAME;
+  const int nb_slots_per_period = ((1<<mu) * NR_NUMBER_OF_SUBFRAMES_PER_FRAME)/nb_periods_per_frame;
   cfg->tdd_table.tdd_period_in_slots = nb_slots_per_period;
 
   if ( (nrofDownlinkSymbols + nrofUplinkSymbols) == 0 )
@@ -105,7 +105,7 @@ void set_tdd_config_nr_ue(fapi_nr_config_request_t *cfg,
     }
   }
 
-  LOG_I(NR_MAC, "TDD has been properly configurated\n");
+  LOG_I(NR_MAC, "TDD has been properly configured\n");
 
 }
 

openair2/LAYER2/NR_MAC_gNB/gNB_scheduler_RA.c

@@ -422,7 +422,7 @@ void nr_schedule_msg2(uint16_t rach_frame, uint16_t rach_slot,
   }
   else{
     if(frame_type == TDD)
-      AssertFatal(1==0,"Dynamic TDD not handled yet\n");
+      AssertFatal(frame_type == FDD, "Dynamic TDD not handled yet\n");
   }