1. 16 Jul, 2024 6 commits
    • Robert Schmidt's avatar
      Remove "global" UE variable reconfig · 3a18c17d
      Robert Schmidt authored
      Variable reconfig is only used in function rrc_add_nsa_user(). Make it
      local to this function to prevent possible bugs (limit the possible
      scope as much as possible).
      3a18c17d
    • Robert Schmidt's avatar
      Refactor generate_CG_Config(): return CG_Config · 6b62c437
      Robert Schmidt authored
      Simplify code by returning an allocated object to a CG_Config.  It leads
      to less code and is easier to reason about, because each call will
      return a new CG_Config, which can be freed, irrespective of other calls
      to fill_default_reconfig().
      6b62c437
    • Robert Schmidt's avatar
      Refactor fill_default_reconfig(): return reconfig · c1668cd7
      Robert Schmidt authored
      Simplify code by returning an allocated object to an RRCReconfiguration.
      It leads to less code and is easier to reason about, because each call
      will return a new RRCReconfiguration, which can be freed, irrespective
      of other calls to fill_default_reconfig().
      c1668cd7
    • Robert Schmidt's avatar
      Clean up servingCellConfigDedicated once after reading config · 4cb0bd37
      Robert Schmidt authored
      get_default_secondaryCellGroup() would "sanitize" the servingCellConfig,
      i.e., remove BWP that are invalid. However, it is difficult to
      understand (we can do sanitization once at the beginning) and reason
      (why the servingCellConfig is modified in
      get_default_secondaryCellGroup(), because all we want is a new
      CellGroupConfig, without modifying other data structures).
      
      Instead, do sanitization once after reading the configuration in
      gnb_config.c. Also, modify physical simulators nr_dlsim and nr_ulsim to
      apply this sanitization before a call to
      get_default_secondaryCellGroup(), as the latter would have done the
      sanitization.
      4cb0bd37
    • Robert Schmidt's avatar
      Revert "Add assertion for known segfault during teardown of gNB." · 98ebd0d7
      Robert Schmidt authored
      This reverts commit 4c658cdd.
      
      This commit was introduce to signal a known segfault. The bug has been
      fixed in the last commit, so this commit can be reverted as the
      AssertFatal is not necessary anymore.
      98ebd0d7
    • Robert Schmidt's avatar
      Create deep copy of ServingCellConfigCommon for UE-specific parameter · 5bde2624
      Robert Schmidt authored
      Prior to this commit, upon a release of a UE at the gNB in NSA, the gNB
      fails with a segv. This is because the servingCellConfigCommon is used
      in the reconfigurationWithSync (through a simple pointer). At the
      release, the entire secondaryCellGroup is freed, leading to a free of
      the servingCellConfigCommon. The gNB then tries to use it (e.g., for
      looking up the numerology), and leading to a segv.
      
      To avoid this problem, make a "deep copy" of the ServingCellConfigCommon
      so that we can safely free the UEs secondaryCellGroup, without freeing
      the initial ServingCellConfigCommon.
      5bde2624
  2. 10 Jul, 2024 1 commit
    • Robert Schmidt's avatar
      Merge branch 'integration_2024_w27' into 'develop' · fefdac73
      Robert Schmidt authored
      Integration: `2024.w27`
      
      See merge request oai/openairinterface5g!2839
      
      * !2781 Fix several ASN.1 message related memory leaks in NR
      * !2790 docker compose override files for testing with locally modified executables.
      * !2835 Demote logs for NR band and duplex spacing
      * !2822 security in re-establishment
      * !2834 Fix CN tutorial SD value
      * !2843 Delete assertion for PLMN in RRCSetupComplete
      * !2771 NR UE PDSCH-CSI overlap
      * !2721 T2 card: LDPC encoder/decoder TB processing
      * !2828 Bugfix to TX_DATA.request PDU_Length computation, change input parameter to uint32_t
      * !2841 Reduce number of LOG prints in NR UE log
      * !2844 phy-test mode ULSCH schdeuler hotfix
      * !2765 Fix issues blocking multiple UE in one process
      * !2826 NR gNB ULSCH fixes
      * !2845 Another phy-test ULSCH fix (missing TDA assignment)
      * !2840 chore(build): removing dependency to libatlas3
      fefdac73
  3. 09 Jul, 2024 12 commits
  4. 08 Jul, 2024 9 commits
  5. 06 Jul, 2024 2 commits
  6. 05 Jul, 2024 10 commits