- 10 Oct, 2024 20 commits
-
-
Robert Schmidt authored
Resolve error: nfapi/oai_integration/aerial/fapi_nvIPC.h:56:16: error: unknown type name ‘nvipc_params_t’ 56 | int nvIPC_Init(nvipc_params_t nvipc_params_s); By including the header. Also, move the definiton of the struct to the MAC, where it is actually stored, and out of the radio common_lib.h, since this is not a radio (split 7/8) parameter.
-
Robert Schmidt authored
We don't use CUDA (see previous commit). Further, the variables referenced in this piece of code are not used later.
-
Robert Schmidt authored
When compiling aerial, we compile without CUDA support (see e.g., docker/Dockerfile.gNB.aerial.ubuntu22). Hence, do not check for it in aerial for the moment, we won't use it for the foreseeable future.
-
Robert Schmidt authored
Since commit e6e25275, preamble_list is an array, not a pointer. Hence, we don't need to call free().
-
Robert Schmidt authored
In Aerial bindings (FAPI-Aerial), the NFAPI mode must be NFAPI_MODE_AERIAL (otherwise, we would not be executing this code). Hence, the switches don't make sense. Remove them. The check can more easily be checked with git show <commit> --ignore-all-space
-
Robert Schmidt authored
As is visible at the top of the patch, for compiling aerial_lib (the binding FAPI-Aerial), we always add ENABLE_AERIAL. Thus, all the code within ENABLE_AERIAL will be compiled; we can also simply take it out.
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Rúben Soares Silva authored
-
Robert Schmidt authored
We can directly read from buffers, so the memcpy() only takes time. Also, limit the scope of the variables for the unpacking of RX_DATA.indication. Co-authored-by: Rúben Soares Silva <rsilva@allbesmart.pt>
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
-
- 01 Oct, 2024 2 commits
-
-
Robert Schmidt authored
the create_workspace.sh script checks if a branch should be merged into what we are trying to checkount (i.e., typically develop into feature-branch). The problem is that it uses a short-hand for an if branch. [ -n "${merge}"] && git merge... If we don't request a merge, [ -n XX ] will evalute to 1, and not do the git merge. Since it's the last command in the script, this makes the script return 1 (failure), when it actually succeeded. Add exit 0 to ensure we return 0 after successful end of the script. If there is a failure, the script will terminate early. It can be tested by e.g., giving a wrong commit ID. Reviewed-by: Jaroslava Fiedlerova <Jaroslava.Fiedlerova@openairinterface.org>
-
Robert Schmidt authored
Integration: `2024.w39` Closes #846 See merge request oai/openairinterface5g!2990 * !2718 Added Jenkins job for Colosseum testing integration * !2901 Fix log2_approx * !2983 fix(docker): making tini download platform specific to support ARM64 native builds * !2919 Add E2 SM in the target dockerfiles * !2981 NR gNB fix PMI report evaluation * !2979 NR-UE: Merging different UE NR SLOT FEP procedures into one. * !2899 SIB19 initialization and scheduling on gNB * !2953 Remove unnecessary c includes * !2926 Fix SRS FAPI at gNB * !2987 fix for variable power in PDSCH REs in case of 25 PRBs Bandwidth * !2993 remove DRX from UE capabilities: not supported yet * !2711 NR UE UL time alignment handling improvements * !2995 some small fixes for 5G NR * !2992 cleaner faster nr_pdcch_demapping_deinterleaving() inner loop * !2986 NR PDCP ticks for F1 split * !2982 CI framework cleanup
-
- 30 Sep, 2024 5 commits
-
-
Jaroslava Fiedlerova authored
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Jaroslava Fiedlerova authored
-
- 29 Sep, 2024 3 commits
-
-
Robert Schmidt authored
Merge remote-tracking branch 'origin/nr_pdcch_demapping_deinterleaving-improve' into integration_2024_w39
-
Robert Schmidt authored
-
Xin Zhe Khooi authored
Currently, NR PDCP ticks are active only with monolithic gNB, triggered by the MAC scheduler in gNB_scheduler.c. In F1 split mode, as there is no MAC, there’s no source to advance the NR PDCP timer via "nr_pdcp_wakeup_timer_thread()". This commit introduces a dedicated thread for NR PDCP ticks in gNB-CU and CU-UP mode. Without it, packet losses at the F1 uplink would cause indefinite buffering, as t-Reordering won't expire due to the lack of NR PDCP timer ticks.
-
- 28 Sep, 2024 10 commits
-
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
Use a script, which can be tested independently of CI code (by running it on the host on which it will be used), and print the directory that has been prepared in the HTML. Also, in the description, use the infinitive/imperative(?) of the verb to harmonize with other steps.
-
Robert Schmidt authored
A lot of CI code is python mixed with bash, e.g., ssh = getConnection(host) ssh.run('ls') ssh.run('echo') At least some of this CI code would benefit if it was written in a simple bash script, returning error codes and potentially other information either through stdout/stderr or files, to the calling Python code: ssh = runScript(host, script) # script does: ls; echo This commit introduces the possibility to run entire scripts. The idea is that the executor has a script (on localhost), which is either executed locally or on a remote host. For the remote host, the script is not copied but piped into a remotely executed bash. In both cases, output is either returned like the Cmd.run() function with returncode and mixed stdout/stderr, or optionally redirected into a file on the (remote) host, which can be treated further by the Python code in later steps.
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
This reimplements the CI deployment functions, and makes them a bit more robust. Concretely: - Introduce a generic "deployment tag" option that can be used to override the tag to use for specific images. By default, it is the current "branch-commitID[0:8]" tag name (requires the change from function ImageTagToUse() to CreateTag(), impacting also pull/push image functions) - Avoid sed for image names, and use an .env file that docker-compose picks up automatically; the deployment analyzes a potentially existing .env file and updates instead of simply overriding. For instance, some pipelines might use -asan images for the gNB and "normal" (non-asan) images for UE, and a simple overwriting might make the -asan image name tag disappear for the gNB, resulting in deployment failures). Finally, undeployment removes the .env file, so that there are no modifications in the repository after undeployment. - Redo the previous behavior of autodetecting asan, and use that (the current function always uses asan, no matter what) - Remove deployKind/displayedNewTags globals, as they are not necessary - Make the usedImage output in HTML slimmer - On undeployment, print service names next to undeploy analysis, and return success/failure. - Make the functions generally less verbose and easier to read Note that as of and only in this commit, deployment does not work, as all the YAML files have not been updated to work with this updated version. The next commit adds tests for the new deployment, and updates one YAML file (also being used in the tests). The follow-up commit then modifies all YAML files.
-
Robert Schmidt authored
The BuildeNB steps either does things that are already implemented (created workspace), or things that we don't use (separate build_wait), and is generally quite convoluted when all it does is calling build_oai. Reimplement by reusing Create_Workspace, and make build_oai in a single step. To clean up, make a new module in which this function does not need a class instantiation. Instead, we give all necessary parameters directly.
-
Robert Schmidt authored
-
Robert Schmidt authored
-