- 16 Jul, 2024 5 commits
-
-
Robert Schmidt authored
Simplify code by returning an allocated object to a CG_Config. It leads to less code and is easier to reason about, because each call will return a new CG_Config, which can be freed, irrespective of other calls to fill_default_reconfig().
-
Robert Schmidt authored
Simplify code by returning an allocated object to an RRCReconfiguration. It leads to less code and is easier to reason about, because each call will return a new RRCReconfiguration, which can be freed, irrespective of other calls to fill_default_reconfig().
-
Robert Schmidt authored
get_default_secondaryCellGroup() would "sanitize" the servingCellConfig, i.e., remove BWP that are invalid. However, it is difficult to understand (we can do sanitization once at the beginning) and reason (why the servingCellConfig is modified in get_default_secondaryCellGroup(), because all we want is a new CellGroupConfig, without modifying other data structures). Instead, do sanitization once after reading the configuration in gnb_config.c. Also, modify physical simulators nr_dlsim and nr_ulsim to apply this sanitization before a call to get_default_secondaryCellGroup(), as the latter would have done the sanitization.
-
Robert Schmidt authored
This reverts commit 4c658cdd. This commit was introduce to signal a known segfault. The bug has been fixed in the last commit, so this commit can be reverted as the AssertFatal is not necessary anymore.
-
Robert Schmidt authored
Prior to this commit, upon a release of a UE at the gNB in NSA, the gNB fails with a segv. This is because the servingCellConfigCommon is used in the reconfigurationWithSync (through a simple pointer). At the release, the entire secondaryCellGroup is freed, leading to a free of the servingCellConfigCommon. The gNB then tries to use it (e.g., for looking up the numerology), and leading to a segv. To avoid this problem, make a "deep copy" of the ServingCellConfigCommon so that we can safely free the UEs secondaryCellGroup, without freeing the initial ServingCellConfigCommon.
-
- 10 Jul, 2024 1 commit
-
-
Robert Schmidt authored
Integration: `2024.w27` See merge request oai/openairinterface5g!2839 * !2781 Fix several ASN.1 message related memory leaks in NR * !2790 docker compose override files for testing with locally modified executables. * !2835 Demote logs for NR band and duplex spacing * !2822 security in re-establishment * !2834 Fix CN tutorial SD value * !2843 Delete assertion for PLMN in RRCSetupComplete * !2771 NR UE PDSCH-CSI overlap * !2721 T2 card: LDPC encoder/decoder TB processing * !2828 Bugfix to TX_DATA.request PDU_Length computation, change input parameter to uint32_t * !2841 Reduce number of LOG prints in NR UE log * !2844 phy-test mode ULSCH schdeuler hotfix * !2765 Fix issues blocking multiple UE in one process * !2826 NR gNB ULSCH fixes * !2845 Another phy-test ULSCH fix (missing TDA assignment) * !2840 chore(build): removing dependency to libatlas3
-
- 09 Jul, 2024 12 commits
-
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
-
francescomani authored
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
Merge remote-tracking branch 'origin/NR_handling_CSI_overlapping_with_PDSCH' into integration_2024_w27
-
Robert Schmidt authored
address sanitizer fails with this error upon starting the DU: ==7==ERROR: AddressSanitizer: odr-violation (0x7f8ed2594a00): [1] size=4 'log_mem_write_side' /oai-ran/common/utils/LOG/log.c:78:14 [2] size=4 'log_mem_write_side' /oai-ran/common/utils/LOG/log.c:78:14 These globals were registered at these points: [1]: #0 0x7f8ed5092658 in __asan_register_globals ../../../../src/libsanitizer/asan/asan_globals.cpp:341 #1 0x7f8ed570d47d in call_init elf/dl-init.c:70 [2]: #0 0x7f8ed5092658 in __asan_register_globals ../../../../src/libsanitizer/asan/asan_globals.cpp:341 #1 0x7f8ed3fe3eba in call_init ../csu/libc-start.c:145 #2 0x7f8ed3fe3eba in __libc_start_main_impl ../csu/libc-start.c:379 ==7==HINT: if you don't care about these errors you may set ASAN_OPTIONS=detect_odr_violation=0 SUMMARY: AddressSanitizer: odr-violation: global 'log_mem_write_side' at /oai-ran/common/utils/LOG/log.c:78:14 So we do as suggested and disable ODR violations to make the test pass. A proper solution would be to link this function only once.
-
- 08 Jul, 2024 9 commits
-
-
francescomani authored
-
Rúben Soares Silva authored
The total_length parameter in compute_PDU_Length being uint16_t causes the passed value to be possibly truncated, which can cause the PDU_Length to be incorrectly calculated. This change prevents that truncation, since it now matches the size of the values passed into the function where it is being called.
-
Robert Schmidt authored
-
Teodora authored
- r_amf->plmn_Identity was interpreted incorrectly, therefore remove it - selected_plmn_identity selects one of the list of PLMNs; at the moment, OAI supports only 1 PLMN ID; print a warning if it is different, and proceed with index 0 More information in issue #801
-
Raphael Defosseux authored
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
-
Raphael Defosseux authored
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
-
francescomani authored
-
francescomani authored
-
Jaroslava Fiedlerova authored
-
- 06 Jul, 2024 2 commits
-
-
Robert Schmidt authored
-
Robert Schmidt authored
-
- 05 Jul, 2024 10 commits
-
-
Bartosz Podrygajlo authored
-
Raphael Defosseux authored
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
-
luis_pereira87 authored
Change UE static IP (use_local_subscription_info: no) network address blocks for a 'Private-Use' range. Address block 12.1.0.0/16 is for public use, so we should not use it for the UEs (https://www.iana.org/assignments/iana-ipv4-special-registry/iana-ipv4-special-registry.xhtml)
-
Stefan Spettel authored
-
Cedric Roux authored
-
Cedric Roux authored
Also adapt callers. In particular nr_pdcp_reestablishment()
-
Cedric Roux authored
-
Cedric Roux authored
- make it work for SRB or DRB - adapt callers of this function - cleanup key derivation: the User Plane keys are generated at some places but are not used, remove the generation
-
Robert Schmidt authored
-
Robert Schmidt authored
-
- 03 Jul, 2024 1 commit
-
-
Robert Schmidt authored
-