1. 19 May, 2020 7 commits
    • Matt Ma's avatar
      Fix and refactor inline functions stack trace. · 2d2c15fc
      Matt Ma authored
      Summary:
      Fix the issue that there may be other tags like DW_TAG_lexical_block between DW_TAG_subprogram and DW_TAG_inlined_subroutine.
      
      Also increase the maximum inline location info per frame since previous value 3 is too small.
      
      Refactors the code to set file and line for inline functions.
      
      Reviewed By: luciang
      
      Differential Revision: D21250080
      
      fbshipit-source-id: f52dc74ee5c144aa26723546b48486f8a5250f19
      2d2c15fc
    • Dan Melnic's avatar
      Fix uninitialized maxSubmit_, maxGet_ member variables · 8228e607
      Dan Melnic authored
      Summary: Fix uninitialized maxSubmit_, maxGet_ member variables
      
      Reviewed By: danobi
      
      Differential Revision: D21645171
      
      fbshipit-source-id: 094ba7b045010954fdebc249318191f956f5b7b2
      8228e607
    • Adam Simpkins's avatar
      make it possible to use folly logging with exceptions disabled · 04b3ad7f
      Adam Simpkins authored
      Summary:
      This updates the logging code so that it is possible to include `folly/xlog.h`
      and write log statements in code that is compiled with `-fno-exceptions`
      
      The code for parsing log configuration strings does still use exceptions in
      some of its config parsing logic.  It shouldn't be too difficult to disable
      that in a subsequent diff, but for now this change at least makes it possible
      for calling code to write log messages.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D21630914
      
      fbshipit-source-id: ce9ed422f40066e57433a85182e1a8fc6d8628db
      04b3ad7f
    • Robin Cheng's avatar
      Fix a minor race condition for ThreadPoolExecutor. · cf7284d0
      Robin Cheng authored
      Summary:
      This fixes a race condition detected by ThreadSanitizer.
      
      The thread list is protected by a mutex, but individual structs in the list are not protected, leading to racy access to two of their fields. This diff makes the fields atomic.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D21484748
      
      fbshipit-source-id: a981419f47a2aebaf1d40b23e9c4967cf2104aaa
      cf7284d0
    • Dan Melnic's avatar
      Remove PollIoBackend inline submit · b412547b
      Dan Melnic authored
      Summary: Remove PollIoBackend inline submit
      
      Reviewed By: danobi
      
      Differential Revision: D21625033
      
      fbshipit-source-id: 02ee55e64a2538c6a2392ea70912f4ae9b642963
      b412547b
    • Lee Howes's avatar
      Add another option to control output formatting of stack traces · 509ab86b
      Lee Howes authored
      Summary:
      The current stack trace formatting is based on repeated string appends with newlines. This change adds more control so that we can produce file and line information only, without unnecessary newlines.
      
      New format:
        ./folly/experimental/symbolizer/Symbolizer.h:77
        ./folly/experimental/symbolizer/test/StackTraceTest.cpp:209
        ./folly/experimental/symbolizer/test/StackTraceTest.cpp:213
        ./folly/experimental/symbolizer/test/StackTraceTest.cpp:258
      
      Reviewed By: yfeldblum
      
      Differential Revision: D21562670
      
      fbshipit-source-id: 7d05605cbda686e2f1c87577647c7ab7581f8580
      509ab86b
    • Kirk Shoop's avatar
      Add ensureCleanupAfterTask · 59a079eb
      Kirk Shoop authored
      Summary:
      adds ensureCleanupAfterTask()
      
      takes a SemiFuture<T> task and a SemiFuture<Unit> cleanup.
      
      returns a SemiFuture<T>
      
      always starts cleanup after task completes. stores the result of the task and replays it after the cleanup completes.
      
      cleanup is not allowed to fail.
      
      Reviewed By: yfeldblum, andriigrynenko
      
      Differential Revision: D21481825
      
      fbshipit-source-id: 901a91c25f7b2b4fa794a590a5433e0fad27d168
      59a079eb
  2. 18 May, 2020 1 commit
  3. 17 May, 2020 1 commit
  4. 15 May, 2020 4 commits
    • Misha Shneerson's avatar
      Add BPF task stats tracepoint to TM and CPU thread pool executor · 2db01ebc
      Misha Shneerson authored
      Summary:
      Allows attaching a BPF script to observe tasks behavior
      
      Sample script, attaching those probes to a test binary (./buck-out/gen/common/services/cpp/test/thrift_2_async_server) is provided.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D21526163
      
      fbshipit-source-id: e976ddada1921c8c904d65aa9a558bbb45bf158f
      2db01ebc
    • Lewis Baker's avatar
      Add CoInvoke() GMock helper for writing safe coroutine lambda versions · 1d98189f
      Lewis Baker authored
      Summary:
      Adds a new CoInvoke() helper function that should be used instead of ::testing::Invoke() when defining mock methods using coroutine lambdas.
      
      Use of Invoke() in a GMock definition that calls a coroutine-lambda that
      contains captures will result in the returned Task holding a dangling reference
      to a copy of the lambda.
      
      The CoInvoke() helper instead, ensures that the coroutine created by the
      lambda holds on to a reference to a copy of the lambda that is kept alive
      until the coroutine completes by invoking the lambda using the folly::coro::co_invoke()
      utility function instead of directly calling operator().
      
      Reviewed By: andriigrynenko
      
      Differential Revision: D21578404
      
      fbshipit-source-id: 3322740efd00596c2311530a166ef2d5301c6b89
      1d98189f
    • Wez Furlong's avatar
      getdeps: upgrade zstd from 1.3.8 -> 1.4.4 · 8cc979ba
      Wez Furlong authored
      Summary:
      I'm doing this mostly so that we can avoid using git
      to fetch the sources.
      
      Reviewed By: chadaustin
      
      Differential Revision: D21508201
      
      fbshipit-source-id: 54d4635d8938659bea962e90bd829d237f1ed221
      8cc979ba
    • Wez Furlong's avatar
      getdeps: windows: avoid expanding drive letter substitutions · 950cdd9b
      Wez Furlong authored
      Summary:
      We use drive letter substitutions to workaround Windows
      filename length limitations.  On my personal Windows system running
      python 3.8.2 realpath inside an ssh session manages to resolve to
      the full filename which causes the boost build to fail.
      
      Avoid that!
      
      Reviewed By: chadaustin
      
      Differential Revision: D21507851
      
      fbshipit-source-id: 1220c1c85d2124ddc51f42cefff2ce00e10c55c9
      950cdd9b
  5. 14 May, 2020 3 commits
    • Yedidya Feldblum's avatar
      Avoid inlining Cursor slow paths · 5b7309d5
      Yedidya Feldblum authored
      Summary: [Folly] Avoid inlining `Cursor` slow paths. These are already extracted to separate functions, but the compiler will still aggressively inline them.
      
      Differential Revision: D21392842
      
      fbshipit-source-id: 2b045ae9c5188315b938de984730ad2051237cf5
      5b7309d5
    • Andrew Huang's avatar
      Give ownership of new session callbacks to SSLContext (v2) · 10eac460
      Andrew Huang authored
      Summary: Giving SSLContext ownership over the new session callback attached to SSL_CTX, so that it may do additional work with the new session (i.e. forward the session to its corresponding abstracted SSLSession).
      
      Reviewed By: mingtaoy
      
      Differential Revision: D21478165
      
      fbshipit-source-id: 459e4b3f9af2fedee4c02df6c9f689db15c1852f
      10eac460
    • Dan Melnic's avatar
      Avoid calling scheduleTimeout for a thread that is mostly busy · d1f8e411
      Dan Melnic authored
      Summary: Avoid calling scheduleTimeout for a thread that is mostly busy
      
      Reviewed By: yfeldblum
      
      Differential Revision: D21531280
      
      fbshipit-source-id: b89254ebc3662c951b3b181b3a2777afb9e3f4fe
      d1f8e411
  6. 13 May, 2020 2 commits
    • Matt Joras's avatar
      Add recvmmsg weak symbol. · ee1e6c7b
      Matt Joras authored
      Summary:
      As it turns out, to use this reliably on Android we need to define a weak symbol. The headers are only exported after API level 21, so apps that compile with 16 cannot use it with a compile time flag.
      
      Instead we can utilize a weak symbol to link with it, and check if it's there at runtime.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D21535034
      
      fbshipit-source-id: 8b68a803d1e9f2f293e9f3efa16fb2a18abee53d
      ee1e6c7b
    • Yedidya Feldblum's avatar
      Explicitly enforce that RequestToken is trivially-destructible · a3e63b14
      Yedidya Feldblum authored
      Summary:
      [Folly] Explicitly enforce that `RequestToken` is trivially-destructible to permit its use as a Meyers Singleton without requiring the use of Leaky Meyers Singleton to avoid destruction-order problems.
      
      (Note: this ignores all push blocking failures!)
      
      Differential Revision: D21533605
      
      fbshipit-source-id: fe334fd5257b1d0a07efd849c4532b28801e54c4
      a3e63b14
  7. 12 May, 2020 3 commits
    • Christopher Wei's avatar
      Add virtual event base interface for getFiberManager · 7c0d945b
      Christopher Wei authored
      Summary: Adds a version of getFiberManager that takes a VirtualEventBase + FrozenOptions
      
      Reviewed By: yfeldblum
      
      Differential Revision: D21507009
      
      fbshipit-source-id: 2bffd1704650b25e78fc388b3e033da4f2c16b9a
      7c0d945b
    • Matt Joras's avatar
      Fix recvmmsg wrapper. · d33c823f
      Matt Joras authored
      Summary: It needs to set the msg_len, otherwise the caller doesn't know how long the datagram is.
      
      Reviewed By: yangchi
      
      Differential Revision: D21512788
      
      fbshipit-source-id: f24c2bd9e86acf93ebf12c48afcf7658c8e8d54e
      d33c823f
    • Dan Melnic's avatar
      Fix sendmmsg wrapper · efb57da2
      Dan Melnic authored
      Summary: Fix sendmmsg wrapper
      
      Reviewed By: yfeldblum
      
      Differential Revision: D21513176
      
      fbshipit-source-id: ddc1bdd93801136994ef62fd5793da7371e9e22a
      efb57da2
  8. 11 May, 2020 4 commits
    • Spencer Baumgardner's avatar
      add support for reference types · fe4c0d46
      Spencer Baumgardner authored
      Summary:
      This diff adds support for reference types to the Async abstraction.
      
      One example use-case is memoization where you generate the value asynchronously on cache-miss. You want may want to return a reference to avoid the expense of copying.
      
      Some additional context is in D21438851.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D21478238
      
      fbshipit-source-id: 53e1b997abed2d40f0a2f9ab935925ad9bbc91ab
      fe4c0d46
    • JiaJie Ye's avatar
      VirtualEventBase is a SequencedExecutor · 0ef1daa2
      JiaJie Ye authored
      Summary:
      VirtualEventBase is backed by a EventBase and byitself is also sequenced, thus shoudl be an SequencedExecutor
      
      (Note: this ignores all push blocking failures!)
      
      Reviewed By: yfeldblum
      
      Differential Revision: D21493098
      
      fbshipit-source-id: 97fd09161117e77422a5786584db89af98dfe314
      0ef1daa2
    • Xavier Deguillard's avatar
      getdeps: add filtering of tests · 7e79b25f
      Xavier Deguillard authored
      Summary:
      For large projects, with lots of tests, running all the tests can take a lot
      of time, but for quick development iteration, only a subset of the tests may
      be needed to run.
      
      On non-Windows platforms, this can be easily achieved by manually executing
      the individual tests binaries and use the builtin filtering mechanism of that
      test binary to achieve the goal. On Windows, this can quickly become
      impossible as DLLs might not be available, and the right PATH would need to
      be manually specified by hand to execute the tests binaries[0].
      
      To solve this, let's simply provide a unified way of running specific tests
      by passing in a regexp. Both testpilot and CTest do support regex to execute
      specific tests. My understanding is that cargo doesn't yet allows regex, but
      will in the future.
      
      [0]: And a missing DLLs would produce no output when executed from
           PowerShell, which makes this very confusing.
      
      Reviewed By: wez
      
      Differential Revision: D21484774
      
      fbshipit-source-id: ee32e950e25bb2a498a2b364a447955a917b0590
      7e79b25f
    • Ian Petersen's avatar
      Modify folly::coro's Malloc.cpp to support iOS <10.0 · 4103ac13
      Ian Petersen authored
      Summary:
      Sized deallocation (introduced in C++14) is only available on iOS after 10.0.
      This diff changes `folly_coro_async_free` to use `operator delete(void*)` when
      `operator delete(void*, size_t)` is unavailable.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D21492467
      
      fbshipit-source-id: 2afef1d3d2aa6c70fec5f49e5d62a4a594e6da83
      4103ac13
  9. 10 May, 2020 1 commit
  10. 09 May, 2020 1 commit
    • Xavier Deguillard's avatar
      getdeps: silence inherits via dominance warnings · aa8735e9
      Xavier Deguillard authored
      Summary:
      Previously, the Windows build was litered with warnings of the form (typo included):
      
        warning C4250: 'C1': inherits 'C2::C2::method' via dominance
        note: see declaration of 'C2::method'
      
      Microsoft doesn't offer any recommendation, and the internet suggest that the
      right `using` should silence it. That's unfortunately not the case, adding:
        using C2::method
      In `C1` doesn't do anything, and the compiler still complains :(.
      
      Since the warning appears to be non-actionable, and looks more like a
      "notice" than a warning, let's just silence it.
      
      Reviewed By: wez
      
      Differential Revision: D21395095
      
      fbshipit-source-id: ae661b3ed61303e6361b8a15d9e7c6b9627ea8c1
      aa8735e9
  11. 08 May, 2020 6 commits
    • Wez Furlong's avatar
      getdeps: try harder to avoid ccache on sandcastle · 47e3c03f
      Wez Furlong authored
      Summary:
      A small number of hosts are impacted by some local misconfiguration like this:
      
      ```
      ccache /usr/bin/c++  -DHAVE_PCLMUL -DHAVE_SSE42 -DOS_LINUX -DROCKSDB_FALLOCATE_PRESENT -DROCKSDB_LIB_IO_POSIX -DROCKSDB_MALLOC_USABLE_SIZE -DROCKSDB_NO_DYNAMIC_EXTENSION -DROCKSDB_PLATFORM_POSIX -DROCKSDB_PTHREAD_ADAPTIVE_MUTEX -DROCKSDB_RANGESYNC_PRESENT -DROCKSDB_SCHED_GETCPU_PRESENT -DROCKSDB_SUPPORT_THREAD_LOCAL -DSNAPPY -I/var/sandcastle/temp/fbcode_builder_getdeps/extracted/rocksdb-v6.8.1.tar.gz/rocksdb-6.8.1 -I/var/sandcastle/temp/fbcode_builder_getdeps/extracted/rocksdb-v6.8.1.tar.gz/rocksdb-6.8.1/include -I/var/sandcastle/temp/fbcode_builder_getdeps/extracted/rocksdb-v6.8.1.tar.gz/rocksdb-6.8.1/third-party/folly -isystem /var/sandcastle/temp/fbcode_builder_getdeps/extracted/rocksdb-v6.8.1.tar.gz/rocksdb-6.8.1/third-party/gtest-1.8.1/fused-src -isystem /var/sandcastle/temp/fbcode_builder_getdeps/installed/snappy-8kzrVQJKWlYwtUKTyQTv0R3_bltgjXecrUEMwSpi-vI/include -W -Wextra -Wall -Wsign-compare -Wshadow -Wno-unused-parameter -Wno-unused-variable -Woverloaded-virtual -Wnon-virtual-dtor -Wno-missing-field-initializers -Wno-strict-aliasing -std=c++11 -fno-omit-frame-pointer -momit-leaf-frame-pointer -fno-builtin-memcmp -O2 -g -DNDEBUG -MD -MT CMakeFiles/rocksdb.dir/cache/lru_cache.cc.o -MF CMakeFiles/rocksdb.dir/cache/lru_cache.cc.o.d -o CMakeFiles/rocksdb.dir/cache/lru_cache.cc.o -c /var/sandcastle/temp/fbcode_builder_getdeps/extracted/rocksdb-v6.8.1.tar.gz/rocksdb-6.8.1/cache/lru_cache.cc
      ccache: error: /home/facebook/.ccache/ccache.conf: No such file or directory
      ```
      
      let's try to avoid it!
      
      Reviewed By: simpkins
      
      Differential Revision: D21460408
      
      fbshipit-source-id: 95b1fe019ff36eb8acb8476af997c220a7947436
      47e3c03f
    • Lukas Piatkowski's avatar
      rust: remove abandoned heapsize crate · 9285064e
      Lukas Piatkowski authored
      Summary: This also unblocks the MacOS Mononoke builds, so enabling them back
      
      Reviewed By: farnz
      
      Differential Revision: D21455422
      
      fbshipit-source-id: 4eae10785db5b93b1167f580a1c887ee4c8a96a2
      9285064e
    • Lukas Piatkowski's avatar
      mononoke/fbcode_builder: bring back mononoke manifests for getdeps build · a0458616
      Lukas Piatkowski authored
      Summary:
      The breakage has been fixed, so bring back the manifest, but only the Linux one, because the Mac version is failing due to another issue.
      
      Also to make it easier to debug issues on GitHub Actions separate out the dependencies build from Mononoke and rust-shed builds.
      
      Reviewed By: krallin
      
      Differential Revision: D21448412
      
      fbshipit-source-id: 68d89c858d1692727a7fd66bca114920e6dfb4dc
      a0458616
    • Nathan Bronson's avatar
      callWithExtractedKey fix for pair of lvalue ref, improvements · 7d618e4f
      Nathan Bronson authored
      Summary:
      callWithExtractedKey previously incorrectly translated
      std::pair<X&,Y&>&& into X&&, Y&&, when reference collapsing rules call
      instead for X& and Y&.  This diff fixes the problem, adds unit tests,
      and also targets the 2-argument std::pair constructor when possible.
      This means that callWithExtractedKey can be safely used on top of
      libc++'s std::unordered_map::emplace without disabling the key-finding
      optimization in that method.  (That lib's emplace is clever enough to
      be able to search on the key before constructing a node, but does not
      include the logic to unwrap the std::pair 3-arg piecewise constructor.)
      
      Reviewed By: yfeldblum
      
      Differential Revision: D21419822
      
      fbshipit-source-id: d3c61e45d7fe7d8c6805342bbe63a8c866f4e306
      7d618e4f
    • Maged Michael's avatar
      ConcurrentHashMap: Add clarifying comments · fa2e7912
      Maged Michael authored
      Summary: Add comments about the performance of frequent removal and mention clear() in the comment about the timing of destruction of removed key-value pairs.
      
      Reviewed By: davidtgoldblatt
      
      Differential Revision: D21455366
      
      fbshipit-source-id: be9f80136260f2de3b68d6fff54ccdadc5544046
      fa2e7912
    • Lewis Baker's avatar
      Add folly::coro::AsyncScope · b7457e50
      Lewis Baker authored
      Summary:
      This class makes it easier to spawn an unbounded number of tasks
      over time within a given scope and then later wait for all of
      those tasks to complete. e.g. during shutdown.
      
      Reviewed By: kirkshoop
      
      Differential Revision: D21391413
      
      fbshipit-source-id: c91c66aa61a8ae30e04d0608426037d8adba14d7
      b7457e50
  12. 07 May, 2020 7 commits
    • Adam Simpkins's avatar
      update AsyncFileWriter to avoid writevFull() on Windows · 8c357b33
      Adam Simpkins authored
      Summary:
      Change folly/logging's AsyncFileWriter code to avoid calling writevFull() on
      Windows.  On POSIX system we use this function to minimize the number of
      system calls we make.  However, on Windows there is no `writev()` function
      provided by the system, so folly emulates this by performing multiple separate
      `write()` calls.  Given that we are just going to perform multiple `write()`
      calls there is no reason to construct the iobuf data structure here.
      
      Differential Revision: D21367424
      
      fbshipit-source-id: 8f6ba9d5fb36318a33d293a416008cd7fa03cb70
      8c357b33
    • Adam Simpkins's avatar
      update AsyncLogWriter::performIO() to take the vector by reference · f121101a
      Adam Simpkins authored
      Summary:
      Update the `AsyncLogWriter::performIO()` API to take the vector of messages by
      const reference, rather than by modifiable pointer.  This parameter is purely
      an input parameter, and shouldn't be modified by the `performIO()` code, so it
      makes more sense to take this as const reference.
      
      Differential Revision: D21367425
      
      fbshipit-source-id: 4bbf3a58dd48bb620101ec3982b189bea656b301
      f121101a
    • Andrii Grynenko's avatar
      Fix blockingWait to schedule task on the DrivableExecutor · 439c7b22
      Andrii Grynenko authored
      Summary: The first portion of the task (before the first suspension point) was run inline.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D21460275
      
      fbshipit-source-id: 31d50e15d5890fbc7127dfff424a4e814dcb2320
      439c7b22
    • Yedidya Feldblum's avatar
      copy_to_unique_ptr, copy_to_shared_ptr · 34ea33d2
      Yedidya Feldblum authored
      Summary: [Folly] `copy_to_unique_ptr`, `copy_to_shared_ptr` - type-deducing wrappers around `make_unique` and `make_shared`.
      
      Reviewed By: vitaut
      
      Differential Revision: D21332222
      
      fbshipit-source-id: f41dac0fcfa972118d3a721194c941e14511a80c
      34ea33d2
    • Ravindra Sunkad's avatar
      Update FBOSS OSS build to link with v4.12.0 of iproute2 · 4fffe6ad
      Ravindra Sunkad authored
      Summary:
      fboss-oss build links to hash that corresponds to tag v4.4.0 released on Jan 11 2016
      
      ```
      repo_url = https://git.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git
      rev = 92a0236a3cdf3438000834121b7ea8a09f1f52b1
      ```
      
      The change is to update the iproute2 version to ```v4.12.0``` (July 5 2017) to match with the version used internally to Facebook
      
      Reviewed By: shri-khare
      
      Differential Revision: D21411714
      
      fbshipit-source-id: fac606396e284193bb7199cf60d2601594bfa5f0
      4fffe6ad
    • Hasnain Lakhani's avatar
      Add manifest for fatal · 15cf7e67
      Hasnain Lakhani authored
      Reviewed By: wez
      
      Differential Revision: D21417542
      
      fbshipit-source-id: f7f0726e84db3dc903bf11c9045a9975a3e90234
      15cf7e67
    • Adam Simpkins's avatar
      define FOLLY_XLOG_STRIP_PREFIXES correctly for all targets · 2c064a01
      Adam Simpkins authored
      Summary:
      The `FOLLY_XLOG_STRIP_PREFIXES` macro tells folly::logging how to strip off
      the absolute portion of the path when automatically computing log category
      names from the source file name.
      
      Previously this was set in FollyCompilerUnix.cmake, which caused it to only be
      applied on Linux/Mac platforms, and only for targets that explicitly used
      `apply_folly_compile_options_to_target()`.
      
      This changes the code to apply this definition with a directory property, so
      it affects all targets under the top-level directory, and it is also applied
      on Windows.
      
      Reviewed By: wez
      
      Differential Revision: D21333014
      
      fbshipit-source-id: 9256e14ab4fd03d19f28957e7ca298c930a22b18
      2c064a01