1. 28 Mar, 2019 2 commits
    • Caleb Marchent's avatar
      Add __pychache__ to .gitignore · 379f9548
      Caleb Marchent authored
      Summary:
      When running shell_building, the tree gets littered with __pycache__ files,
      hence ignore them.
      
      Reviewed By: wez
      
      Differential Revision: D14664303
      
      fbshipit-source-id: d41837cdfda1ae93c2d9330f00284128b3f7f7d0
      379f9548
    • Lewis Baker's avatar
      Add support for folly::coro::Task<T&> · 13560466
      Lewis Baker authored
      Summary:
      Extended `folly::coro::Task` to support an lvalue-reference value type.
      
      A `Task<T&>` stores the value internally in a `folly::Try<std::reference_wrapper<T>>` as `folly::Try` does not support reference value types. This means that when you use `co_await task.co_awaitTry()` on a `Task<T&>` that you get back a `folly::Try<std::reference_wrapper<T>>` instead of a `folly::Try<T&>`.
      
      Also added support for using `.co_awaitTry()` on `Task<T>`.
      Previously the `.co_awaitTry()` method was only supported on the `TaskWithExecutor<T>` type.
      
      Reviewed By: andriigrynenko
      
      Differential Revision: D14657997
      
      fbshipit-source-id: a168991b5a9c278dcc2387a6ff4fba9e47ccac0d
      13560466
  2. 27 Mar, 2019 10 commits
    • Dan Melnic's avatar
      Fix for the HHWheelTimer broken Windows build · f5977149
      Dan Melnic authored
      Summary:
      Fix for the HHWheelTimer broken Windows build
      
      (Note: this ignores all push blocking failures!)
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14642461
      
      fbshipit-source-id: 07292429b1e27eafeb144ab529940aee86dcca6d
      f5977149
    • David Lam's avatar
      Fix some typos in folly/io/IOBuf.h documentation · 047526d5
      David Lam authored
      Summary: As title.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14638826
      
      fbshipit-source-id: 1904a1e416f299c2cafc147a3eb15dad325ae240
      047526d5
    • Caleb Marchent's avatar
      Allow LogDevice to build without Submodules (#71) · a8422464
      Caleb Marchent authored
      Summary:
      As a step in the plan to migrate LogDevice to using fbcode_builder as
      the primary build method, allow LogDevice to build without submodules.
      In place of the self compiled modules, the CMake scripts will look in
      the system (or provided prefix locations) and use precompiled modules
      there. Users can then use fbcode_builder to ensure those required
      modules are built and available.
      
      * Use new 'folly_test_util' library rather than referencing sources
      directly
      Pull Request resolved: https://github.com/facebookincubator/LogDevice/pull/71
      
      Reviewed By: AhmedSoliman
      
      Differential Revision: D14578119
      
      Pulled By: calebmarchent
      
      fbshipit-source-id: 36400d41d3f1906919706d20d0fb53195fec2e63
      a8422464
    • Qi Wang's avatar
      Avoid allocation from the hugepage allocator alloc_hook. · 546a879d
      Qi Wang authored
      Summary:
      The alloc_hook is invoked on the malloc path. Therefore we should not
      allocate on this path.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14605677
      
      fbshipit-source-id: f95b9ff3e14f65781045d26ce59ec008c113ca81
      546a879d
    • Yedidya Feldblum's avatar
      Back out D14608368 to HHWheelTimerBase · c0980078
      Yedidya Feldblum authored
      Summary:
      Back out D14608368 "HHWheelTimerBase: use different DEFAULT_TICK_INTERVAL values for milliseconds and microseconds".
      
      The change being backed out breaks the MSVC build; backing it out should restore the MSVC build.
      
      Fixes #1087.
      
      Differential Revision: D14638652
      
      fbshipit-source-id: b06b2934771adeff7a49c54b33da84a5bc973e66
      c0980078
    • Kirk Shoop's avatar
      fix real-concepts builds · 24e531f7
      Kirk Shoop authored
      Summary: removed constraints that are no longer valid.
      
      Reviewed By: ericniebler
      
      Differential Revision: D14606943
      
      fbshipit-source-id: bf7acb88e3b6202caaa3e1333d88e5c516eb18e3
      24e531f7
    • Tom Jackson's avatar
      Make pmap() handle exceptions instead of FATALing · 88ba2915
      Tom Jackson authored
      Summary:
      This switches the output queue from `Output` to `Expected<Output, std::exception_wrapper>`, allowing exceptions to be produced by the predicate. Prior to this change, any exceptions would FATAL, taking down the whole process.
      
      Benchmarks appear unaffected. Memory use will be very similar: Small objects are already padded out to a cache line, so the increase in size will often be zero.
      
      Reviewed By: luciang
      
      Differential Revision: D14625210
      
      fbshipit-source-id: 9bfa1197b7d2285bbc7e42e829beeb3525b3bd44
      88ba2915
    • Tom Jackson's avatar
      Guard is broken · 848e0fa0
      Tom Jackson authored
      Summary: Adding note and disabled test for now, will come back to fixing or killing this later.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14625209
      
      fbshipit-source-id: 6e4f523c02e28fa6080da16485cba68ee78ffc80
      848e0fa0
    • Fred Emmott's avatar
      Revert D13966702: [fbcode] AsyncServerSocket::AcceptCallback::connectionAccepted to NetworkSocket · d58678d6
      Fred Emmott authored
      Differential Revision:
      D13966702
      
      Original commit changeset: 415622dc347d
      
      fbshipit-source-id: 11ff9cac08174cfaefe20e7e4c5e08dc005aaa39
      d58678d6
    • Wez Furlong's avatar
      folly: remove problematic -Wnon-virtual-dtor error from cmake build · 9688659c
      Wez Furlong authored
      Summary:
      This causes problems with the cmake build because boost
      triggers this warning, and we're promoting this to an error.
      
      It is possible to use `-isystem` to tell the compiler that the
      the boost headers are system headers, but introducing that for
      boost headers is a mess.
      
      We can safely live without this warning in the open source build
      as our buck based builds have this enabled correctly.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14631786
      
      fbshipit-source-id: cf30d0921ce592f410c2ad4bfddba1bddef01ed7
      9688659c
  3. 26 Mar, 2019 7 commits
    • Dan Melnic's avatar
      HHWheelTimerBase: use different DEFAULT_TICK_INTERVAL values for milliseconds and microseconds · bc269446
      Dan Melnic authored
      Summary: HHWheelTimerBase: use different DEFAULT_TICK_INTERVAL values for milliseconds and microseconds
      
      Reviewed By: djwatson
      
      Differential Revision: D14608368
      
      fbshipit-source-id: 81ca30dead56e0ec954fce05c9f920e15dc20405
      bc269446
    • Joe Loser's avatar
      Fix Clang 8 -Wdefaulted-function-deleted errors (#1082) · 0029def9
      Joe Loser authored
      Summary:
      - Clang 8 introduces a new compiler option which is turned on by
        default: `-Wdefaulted-function-deleted`.
      - This flags some code which has special member functions which we
        declare as defaulted, but are implicitly deleted. As such, it is a bit
        misleading to mark them as defaulted. So, mark them as deleted. We
        could also remove them and they would be implicitly deleted, but then
        the internal linter would not like that we define a user defined type
        but are not explicit about deleting or defaulting all special member
        functions.
      
      Note:
      - This fixes some Clang 8 compilation issues, but
        https://github.com/facebook/folly/issues/1081 contains details about the
        remaining issues.
      Pull Request resolved: https://github.com/facebook/folly/pull/1082
      
      Reviewed By: Orvid
      
      Differential Revision: D14613574
      
      Pulled By: yfeldblum
      
      fbshipit-source-id: 8011b3bc456bf92bbaf374c045fffb130e26d38b
      0029def9
    • Orvid King's avatar
      AsyncServerSocket::AcceptCallback::connectionAccepted to NetworkSocket · 6b559d40
      Orvid King authored
      Summary: This is a largely automated codemod that shifts `folly::AsyncServerSocket::AcceptCallback::connectionAccepted` to taking a `NetworkSocket` rather than a file descriptor. This needs to be done as a single atomic change to avoid breaking things.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D13966702
      
      fbshipit-source-id: 415622dc347de53368c404dfbe9a2deae5b75e18
      6b559d40
    • Joe Loser's avatar
      Use feature test macro for deduction guide in Replaceable.h (#1065) · b9a450ef
      Joe Loser authored
      Summary:
      - Replace a check for deduction guide support to use a feature test macro
        for deduction guides rather than a check using `__cplusplus` directive.
      - The existing check using the `__cplusplus` directive is not correct
        for GCC 5.1. With GCC 5.1, `__cplusplus > 201402L` will be true, but the check
        for `#if __cpp_deduction_guides >= 201703` will be false. So, it is
        not valid to just rely on the `__cplusplus` directive to infer
        deduction guide support.
      - We extend the check to use the feature test macro except in the case
        of MSVC, which we infer the feature is supported. MSVC does not define
        feature test macros, despite having implemented the feature.
      Pull Request resolved: https://github.com/facebook/folly/pull/1065
      
      Reviewed By: aary
      
      Differential Revision: D14518809
      
      Pulled By: yfeldblum
      
      fbshipit-source-id: a976ae527ef986ae6d3fc52c316af9bf8e209767
      b9a450ef
    • Yedidya Feldblum's avatar
      Cut FOLLY_CACHE_LINE_SIZE · d1ef780f
      Yedidya Feldblum authored
      Summary:
      [Folly] Cut `FOLLY_CACHE_LINE_SIZE` macro, replacing uses with `folly::hardware_destructive_interference_size`.
      
      As one oddity, `FOLLY_CACHE_LINE_SIZE` had value 64 while `folly::hardware_destructive_interference_size` has value 128, so some types may get larger.
      
      Reviewed By: aary
      
      Differential Revision: D14574695
      
      fbshipit-source-id: 7c5b9e313c5dcdecfec3cc47ec7bd55d08ae762c
      d1ef780f
    • Aaryaman Sagar's avatar
      Add flat combining to DistributedMutex · f11ea4c6
      Aaryaman Sagar authored
      Summary:
      Add combined critical sections to DistributedMutex.  The implementation uses
      the framework within DistributedMutex as the point of reference for contention
      and resolves contention by either combining the lock requests of peers or
      migrating the lock based on usage and internal state.  This boosts the
      performance of DistributedMutex more than before - up to 4x relative to the
      old benchmark on dual socket Broadwell and up to 5x on single socket Skylake
      machines.  The win might be bigger when the cost of mutex migration is higher,
      eg.  when the data being protected is wider than a single L1 cache line.
      Small critical sections when used in combinable mode, can now go more than 10x
      faster than the small locks, about 6x faster than std::mutex, up to 2-3x
      faster than the implementations of flat combining we benchmarked against and
      about as fast as a CAS instruction/loop (faster on some NUMA-less and more
      parallel architectures like Skylake).  This also allows flat combining to be
      used in situations where fine-grained locking would be beneficial with
      virtually no overhead, DistributedMutex retains the original size of 8 bytes.
      DistributedMutex resolves contention through flat combining up to a constant
      factor of 2 contention chains to prevent issues with fairness and latency
      outliers.  So we retain the fairness benefits of the original implementation
      with no noticeable regression when switching between the lock methods.
      
      The implementation of combined critical sections here is different from the
      original flat combining paper.  This uses the same stack based LIFO contention
      chains from DistributedMutex to allow the leader to resolve lock requests from
      peers.  Combine records are located on the stack along with the wait-node as an
      InlineFunctionRef instance to avoid memory allocation overhead or expensive
      copying.  Using InlineFunctionRef also means that function calls are resolved
      without having to go through the double lookup of a vtable based implementation.
      InlineFunctionRef can flatten the virtual table and callable object in-situ
      so we have just one indirection.  Additionally, we use preemption as a signal
      to speed up lock requests in the case where latency of acquisition would have
      otherwise gone beyond our control.  As a side-bonus, this also results in much
      simpler code.
      
      The API looks like the following
      ```
      auto integer = std::uint64_t{};
      auto mutex = folly::DistributedMutex{};
      
      // ...
      
      mutex.lock_combine([&]() {
        foo();
        integer++;
      });
      ```
      
      This adds three new methods for symmetry with the old lock functions
      - folly::invoke_result_t<const Func&> lock_combine(Func) noexcept;
      - folly::Optional<> try_lock_combine_for(duration, Func) noexcept;
      - folly::Optional<> try_lock_combine_until(time_point, Func) noexcept;
      
      Benchmarks on Broadwell
      ```
      std_mutex_simple(1thread)                                  617.28ns    1.62M
      google_spin_simple(1thread)                      101.97%   605.33ns    1.65M
      folly_microspin_simple(1thread)                   99.40%   621.01ns    1.61M
      folly_picospin_simple(1thread)                   100.15%   616.36ns    1.62M
      folly_microlock_simple(1thread)                   98.86%   624.37ns    1.60M
      folly_sharedmutex_simple(1thread)                 86.14%   716.59ns    1.40M
      folly_distributedmutex_simple(1thread)            97.95%   630.21ns    1.59M
      folly_distributedmutex_flatcombining_simple(1th   98.04%   629.60ns    1.59M
      folly_flatcombining_no_caching_simple(1thread)    89.85%   687.01ns    1.46M
      folly_flatcombining_caching_simple(1thread)       78.36%   787.75ns    1.27M
      atomics_fetch_add(1thread)                        97.88%   630.67ns    1.59M
      atomic_cas(1thread)                              102.31%   603.33ns    1.66M
      ----------------------------------------------------------------------------
      std_mutex_simple(2thread)                                    1.14us  875.72K
      google_spin_simple(2thread)                      125.08%   912.95ns    1.10M
      folly_microspin_simple(2thread)                  116.03%   984.14ns    1.02M
      folly_picospin_simple(2thread)                   117.35%   973.04ns    1.03M
      folly_microlock_simple(2thread)                  102.54%     1.11us  897.95K
      folly_sharedmutex_simple(2thread)                121.04%   943.42ns    1.06M
      folly_distributedmutex_simple(2thread)           128.24%   890.48ns    1.12M
      folly_distributedmutex_flatcombining_simple(2th  107.99%     1.06us  945.66K
      folly_flatcombining_no_caching_simple(2thread)    83.40%     1.37us  730.33K
      folly_flatcombining_caching_simple(2thread)       87.47%     1.31us  766.00K
      atomics_fetch_add(2thread)                       115.71%   986.85ns    1.01M
      atomic_cas(2thread)                              171.35%   666.42ns    1.50M
      ----------------------------------------------------------------------------
      std_mutex_simple(4thread)                                    1.98us  504.43K
      google_spin_simple(4thread)                      103.24%     1.92us  520.76K
      folly_microspin_simple(4thread)                   92.05%     2.15us  464.33K
      folly_picospin_simple(4thread)                    89.16%     2.22us  449.75K
      folly_microlock_simple(4thread)                   66.62%     2.98us  336.06K
      folly_sharedmutex_simple(4thread)                 82.61%     2.40us  416.69K
      folly_distributedmutex_simple(4thread)           108.83%     1.82us  548.98K
      folly_distributedmutex_flatcombining_simple(4th  145.24%     1.36us  732.63K
      folly_flatcombining_no_caching_simple(4thread)    84.77%     2.34us  427.62K
      folly_flatcombining_caching_simple(4thread)       91.01%     2.18us  459.09K
      atomics_fetch_add(4thread)                       142.86%     1.39us  720.62K
      atomic_cas(4thread)                              223.50%   887.02ns    1.13M
      ----------------------------------------------------------------------------
      std_mutex_simple(8thread)                                    3.70us  270.40K
      google_spin_simple(8thread)                      110.24%     3.35us  298.09K
      folly_microspin_simple(8thread)                   81.59%     4.53us  220.63K
      folly_picospin_simple(8thread)                    57.61%     6.42us  155.77K
      folly_microlock_simple(8thread)                   54.18%     6.83us  146.49K
      folly_sharedmutex_simple(8thread)                 55.44%     6.67us  149.92K
      folly_distributedmutex_simple(8thread)           109.86%     3.37us  297.05K
      folly_distributedmutex_flatcombining_simple(8th  225.14%     1.64us  608.76K
      folly_flatcombining_no_caching_simple(8thread)    96.25%     3.84us  260.26K
      folly_flatcombining_caching_simple(8thread)      108.13%     3.42us  292.39K
      atomics_fetch_add(8thread)                       255.40%     1.45us  690.60K
      atomic_cas(8thread)                              183.68%     2.01us  496.66K
      ----------------------------------------------------------------------------
      std_mutex_simple(16thread)                                   8.70us  114.89K
      google_spin_simple(16thread)                     124.47%     6.99us  143.01K
      folly_microspin_simple(16thread)                  86.46%    10.07us   99.34K
      folly_picospin_simple(16thread)                   40.76%    21.36us   46.83K
      folly_microlock_simple(16thread)                  54.78%    15.89us   62.94K
      folly_sharedmutex_simple(16thread)                58.14%    14.97us   66.80K
      folly_distributedmutex_simple(16thread)          124.53%     6.99us  143.08K
      folly_distributedmutex_flatcombining_simple(16t  324.08%     2.69us  372.34K
      folly_flatcombining_no_caching_simple(16thread)  134.73%     6.46us  154.79K
      folly_flatcombining_caching_simple(16thread)     188.24%     4.62us  216.28K
      atomics_fetch_add(16thread)                      340.07%     2.56us  390.72K
      atomic_cas(16thread)                             220.15%     3.95us  252.93K
      ----------------------------------------------------------------------------
      std_mutex_simple(32thread)                                  25.62us   39.03K
      google_spin_simple(32thread)                     105.21%    24.35us   41.07K
      folly_microspin_simple(32thread)                  79.64%    32.17us   31.08K
      folly_picospin_simple(32thread)                   19.61%   130.67us    7.65K
      folly_microlock_simple(32thread)                  42.97%    59.62us   16.77K
      folly_sharedmutex_simple(32thread)                52.41%    48.88us   20.46K
      folly_distributedmutex_simple(32thread)          144.48%    17.73us   56.39K
      folly_distributedmutex_flatcombining_simple(32t  461.73%     5.55us  180.22K
      folly_flatcombining_no_caching_simple(32thread)  207.55%    12.34us   81.01K
      folly_flatcombining_caching_simple(32thread)     237.34%    10.80us   92.64K
      atomics_fetch_add(32thread)                      561.68%     4.56us  219.23K
      atomic_cas(32thread)                             484.13%     5.29us  188.96K
      ----------------------------------------------------------------------------
      std_mutex_simple(64thread)                                  31.26us   31.99K
      google_spin_simple(64thread)                      99.95%    31.28us   31.97K
      folly_microspin_simple(64thread)                  83.63%    37.38us   26.75K
      folly_picospin_simple(64thread)                   20.88%   149.68us    6.68K
      folly_microlock_simple(64thread)                  45.46%    68.77us   14.54K
      folly_sharedmutex_simple(64thread)                52.65%    59.38us   16.84K
      folly_distributedmutex_simple(64thread)          154.90%    20.18us   49.55K
      folly_distributedmutex_flatcombining_simple(64t  475.05%     6.58us  151.96K
      folly_flatcombining_no_caching_simple(64thread)  195.63%    15.98us   62.58K
      folly_flatcombining_caching_simple(64thread)     199.29%    15.69us   63.75K
      atomics_fetch_add(64thread)                      580.23%     5.39us  185.61K
      atomic_cas(64thread)                             510.76%     6.12us  163.39K
      ----------------------------------------------------------------------------
      std_mutex_simple(128thread)                                 70.53us   14.18K
      google_spin_simple(128thread)                     99.20%    71.09us   14.07K
      folly_microspin_simple(128thread)                 88.73%    79.49us   12.58K
      folly_picospin_simple(128thread)                  22.24%   317.06us    3.15K
      folly_microlock_simple(128thread)                 50.17%   140.57us    7.11K
      folly_sharedmutex_simple(128thread)               59.53%   118.47us    8.44K
      folly_distributedmutex_simple(128thread)         172.74%    40.83us   24.49K
      folly_distributedmutex_flatcombining_simple(128  538.22%    13.10us   76.31K
      folly_flatcombining_no_caching_simple(128thread  165.11%    42.72us   23.41K
      folly_flatcombining_caching_simple(128thread)    161.46%    43.68us   22.89K
      atomics_fetch_add(128thread)                     606.51%    11.63us   85.99K
      atomic_cas(128thread)                            578.52%    12.19us   82.03K
      ```
      
      Reviewed By: djwatson
      
      Differential Revision: D13799447
      
      fbshipit-source-id: 923cc35e5060ef79b349690821d8545459248347
      f11ea4c6
    • Joe Loser's avatar
      Fix FBStringTest to work with CMake 3.9 or later (#1080) · 11566445
      Joe Loser authored
      Summary:
      - CMake 3.9 or later has the `GoogleTest` module which allows for the
        ability to automatically add tests to CTest by scanning the source code
        for Google Test Macros. This is used in `CMake/FollyFunctions.cmake`.
        However, this scanning is just exact string search without full context.
        So, this flags a comment in  `FBStringTest.cpp`. As a result, it tries to
        register the comment matching the macro as a new test. Since the comment
        matches an exact test case which has already been defined, this results in
        a hard error as you cannot have two test cases of the same name in the same
        test suite. The error is as follows:
      
      ```
        add_test given test NAME "fbstring_test.FBString.testMoveCtor" which
        already exists in this directory.
      Call Stack (most recent call first):
        CMake/FollyFunctions.cmake:268 (gtest_add_tests)
        CMakeLists.txt:481 (folly_define_tests)
      ```
      
      - Fix the comment to keep the same intent but not get treated as a test
        registration.
      Pull Request resolved: https://github.com/facebook/folly/pull/1080
      
      Differential Revision: D14613558
      
      Pulled By: yfeldblum
      
      fbshipit-source-id: 74ebef0ba9a8690ff8f3dfd4cd049f72114ef9a5
      11566445
  4. 25 Mar, 2019 10 commits
  5. 23 Mar, 2019 1 commit
  6. 22 Mar, 2019 10 commits
    • Wez Furlong's avatar
      watchman:folly:thrift:wangle:fizz: move CMake library bits to a central location · dee270d9
      Wez Furlong authored
      Summary:
      Use the watchman cmake files to seed the common cmake library and adjust
      a number of our opensource projects to take their glog and gflags module
      finding from that central location.
      
      Note that there are a variety of ad-hoc re-implementations of shipit in various build scripts used in sandcastle jobs at the moment that result in adding multiple cmake module paths to correctly locate the shared cmake directory.  The long term solution is to get all those projects integrated in the new fbcode_builder stuff that I'm working on.
      
      Reviewed By: simpkins, calebmarchent
      
      Differential Revision: D14549654
      
      fbshipit-source-id: e49a7f20a15af52b4b3ed3037b8973fc293656dc
      dee270d9
    • Eric Niebler's avatar
      remove executor category properties; refactor, simplify, remove concepts. · 059ca1b2
      Eric Niebler authored
      Summary:
      Now that we have `.schedule()`, We can syntactically determine what things are executors and which are not. We can also tell what kind of executor, be it constrained, or time, or neither. Therefore, we no longer need the `is_executor<>` property query. Nuke it.
      
      In addition, all the `Sender`, `Receiver`, and `Executor` concepts, in addition to testing for the required syntac, took an arbitrary number of properties to query. Those were breaking subsumption relationships (e.g., `Sender<From, is_many<>>` doesn't subsume `Sender<From>`). Move those property queries out of the concept heirarchy and into separate algorithm requirements that test the properties directly.
      
      Reviewed By: kirkshoop
      
      Differential Revision: D14570712
      
      fbshipit-source-id: 8ae0d96e5c9f00dcea3fbff4bbbe04c71bb0df07
      059ca1b2
    • Eric Niebler's avatar
      bring bit-rotted pushmi examples back from the dead · 323f42e1
      Eric Niebler authored
      Summary: Several of the pushmi examples needed a working thread pool. Use the new one in pushmi/examples/pool.h, and bring the examples up-to-date with recent pushmi changes.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D14563479
      
      fbshipit-source-id: 70def2adc90fdf3eb5eef929245f39b294209cbe
      323f42e1
    • Eric Niebler's avatar
      add pool_executor in pushmi/examples/pool.h, use it when updating the pushmi... · 594ff7a5
      Eric Niebler authored
      add pool_executor in pushmi/examples/pool.h, use it when updating the pushmi benchmark and migrating it to Folly.Benchmark
      
      Summary: The PushmiBenchmark was badly bit-rotted. Update it for the latest pushmi design, migrate it to Folly.Benchmark, and implement it in terms of a new pushmi::pool_executor that is a thin wrapper over a pointer to a folly::CPUThreadPoolExecutor.
      
      Reviewed By: kirkshoop
      
      Differential Revision: D14550589
      
      fbshipit-source-id: d808d6f5795ead421e6ee88439adb9ee652d3146
      594ff7a5
    • Yedidya Feldblum's avatar
      Enforce C++14 or later · 79f11efb
      Yedidya Feldblum authored
      Summary:
      [Folly] Enforce C++14 or later.
      
      Could alternatively do it via C++14-only syntax which would work for all target compilers, but this way the intention is clearest.
      
      Reviewed By: mzlee
      
      Differential Revision: D13649917
      
      fbshipit-source-id: 0783dfd3e471d32626bbd44cc22584d83b5c21d4
      79f11efb
    • Phil Willoughby's avatar
      allocated size of Function · bf27b4af
      Phil Willoughby authored
      Summary:
      The intent is to allow heavy users of Function to determine the runtime weight of each of them and evaluate functionally-equivalent options for their code structure (for example: lambda vs function vs `std::bind`) to pick the most space-efficient on their platform.
      
      Limitations
      =
      If the real function type defines a custom `operator new` that allocates a different amount of memory than `sizeof(...)` suggests it should: that will not be accounted correctly.
      
      We can't look into the real function type at what it itself has allocated. This means that if you capture a unique_ptr to `null` or a unique_ptr to a 4Gb buffer the reported size will be the same.
      
      Reviewed By: ericniebler
      
      Differential Revision: D14512815
      
      fbshipit-source-id: dc636c8bebddabceaeaa8b869bf37c7f0c64c017
      bf27b4af
    • Yedidya Feldblum's avatar
      LifoSem::try_wait · 3d77e1b3
      Yedidya Feldblum authored
      Summary: [Folly] `LifoSem::try_wait`, a synonym for `tryWait`.
      
      Reviewed By: magedm
      
      Differential Revision: D14538142
      
      fbshipit-source-id: 5989223a36cddafca108ebdbafc2b17e8dda5964
      3d77e1b3
    • Yedidya Feldblum's avatar
      Fix semaphore usage in UnboundedBlockingQueue · 053c2e89
      Yedidya Feldblum authored
      Summary:
      [Folly] Fix semaphore usage in `UnboundedBlockingQueue`.
      
      Ensure that `wait` is paired 1:1 with `post`.
      
      Reviewed By: davidtgoldblatt, magedm
      
      Differential Revision: D14537954
      
      fbshipit-source-id: def54263da1a33c1b3ffa1de237a2b786572759a
      053c2e89
    • Yedidya Feldblum's avatar
      Benchmark for UnboundedBlockingQueue · 028e81b5
      Yedidya Feldblum authored
      Summary: [Folly] Benchmark for `UnboundedBlockingQueue`, starting with measuring contention of `take()`.
      
      Reviewed By: magedm
      
      Differential Revision: D14537953
      
      fbshipit-source-id: ddbba705787b39377f94ad0d63e85038305116cc
      028e81b5
    • Lewis Baker's avatar
      Add folly::coro::AsyncGenerator<T> · a0d2309a
      Lewis Baker authored
      Summary:
      The AsyncGenerator<T> class allows you to write a coroutine that asynchronously produces a sequence of values of type T.
      
      This has the same executor-affinity behaviour for co_await as for Task<T> except that the executor can change at co_yield points to inherit the executor from the consumer each time a new value is requested.
      
      Reviewed By: ericniebler
      
      Differential Revision: D14446089
      
      fbshipit-source-id: 710ad922918a135e1fe6eef853410c9a77cc2c28
      a0d2309a