Summary: Nothing breaks so....

Reviewed By: yfeldblum, siyengar

Differential Revision: D4377965

fbshipit-source-id: 53c42e7f6f3a71aedd4b9a089ffca9d3c8472029

Reviewed By: yfeldblum

Differential Revision: D7832437

fbshipit-source-id: 036a89693e247e0d6356980c3bf9db84d322f408

Summary: This abstraction is currently only used in functions executed on Python threads, so it should be unecessary.

Reviewed By: andriigrynenko

Differential Revision: D7828136

fbshipit-source-id: a9ea8b23ffc26505c576106c49e850e1894648d5

Summary: This should allow better differentation between compilers in situations where warnings need to be disabled for a specific compiler. I've reclaimed the GCC_DISABLE version to have it now refer to only GCC, rather than GCC+CLANG, and also added a version for clang only.

Reviewed By: yfeldblum

Differential Revision: D7834730

fbshipit-source-id: 7e0b076f5d9bc55870cfb7e67281190b4add82e6

Summary:
future/semifuture move-assignment operators call this->assign(). The latter's arg was passed as an lvalue-ref. Result: now that arg is an rvalue-ref.

Note: I adjusted the assign() calling convention to avoid a forwarding ref. It would have been okay but it's easier to avoid a forwarding-ref than to explain why it happens to always be an rvalue-ref.

Reviewed By: yfeldblum

Differential Revision: D7831539

fbshipit-source-id: cf1c66cd498f768905ac3d21e39f693d7a652b39

Summary:
This diff adds support for the F14 algorithm using the advanced
SIMD instructions (NEON) that are part of aarch64.

Reviewed By: yfeldblum

Differential Revision: D7765273

fbshipit-source-id: 866a8a3481ad60b8aadcfb39718d6a5e62bbe07c

Summary:
Forwarding refs may hold lvalue-refs as well as rvalue-refs, so generally should be forward'd not move'd (to avoid erroneously consuming an lvalue).

The `initial` param of `folly::reduce(first, last, initial, func)` (also used by `folly::reduce(container, initial, func)`) is a forwarding-ref but the code used `std::move(initial)`. Goal: change that to `std::forward<T>(initial)`.

Reviewed By: yfeldblum

Differential Revision: D7827721

fbshipit-source-id: 12d4ee0ae3cfb0de71269575289c7cd8246eb468

Summary: (self explanatory)

Reviewed By: yfeldblum

Differential Revision: D7825123

fbshipit-source-id: 60c99950b3af351536c0fd0ba306b5796572e1b6

Summary:
Make these const:
- {Future,SemiFuture}::hasValue()
- {Future,SemiFuture}::hasException()
- {Future,SemiFuture}::isActive()
- Promise::throwIfFulfilled()

Reviewed By: yfeldblum

Differential Revision: D7824879

fbshipit-source-id: 035b4bbcfd5b88825580e22b37b13e07158898f3

Summary:
Avoid swap() in move-ctor:
  - slightly faster
  - frees resources eagerly/sooner vs. later

Side benefit: added `noexcept` to a few appropriate methods.

Reviewed By: yfeldblum

Differential Revision: D7723078

fbshipit-source-id: f2d08b5ce094c42cb114deda7a6841052d1b785a

Summary:
Timekeeper.h had a weird circular dependence issue that would show up when
included from within the future implementation headers.  The stuff in
Timekeeper.h should ideally be within the future headers themselves

Reviewed By: yfeldblum, Orvid

Differential Revision: D7787275

fbshipit-source-id: a6309c0cc5edca4f5bd12d2651c828299681df54

Summary: Remove the Logging.h shim that was simply redirecting includes to GLog.h

Reviewed By: yfeldblum

Differential Revision: D7783879

fbshipit-source-id: 8d1c1d8501c6a2b067ef72471885fedb3e9f7b10

Reviewed By: yfeldblum

Differential Revision: D7819076

fbshipit-source-id: 1dae43c27b88ea1a78d2a54f556687e8c4bbc008

Summary: Add previous for EliasFano reader. Here the equation is: reader == reader.next().previous();

Reviewed By: ot

Differential Revision: D7497171

fbshipit-source-id: 33dc3316036b94a5da278c328322ea4c3322588e

Summary:
- Fix all cases of "segfault if consumed/moved-out"
  - In Future, SemiFuture, Promise.
  - Those now throw NoState instead.

Reviewed By: yfeldblum

Differential Revision: D7721921

fbshipit-source-id: 76fafcbd30e23d63150196d3d7e404f348b220f2

Summary: There isn't a good way to access ThreadPoolExecutors to add instrumentation, such as grabbing basic stats on all executors to better understand pool capacity. This provides a way to do that.

Reviewed By: yfeldblum, djwatson

Differential Revision: D7658144

fbshipit-source-id: 3e72acdccf25742b76d438d2895d586049a0cc17

Summary:
MicroSpinLock was doing a non-relaxed load before cas, which seems odd because typically we expect spin locks to be unlocked. This diff flips the order and assumes the lock is unlocked before doing a load-loop.

While the benchmark results for SmallLocksBenchmark are a little mixed, the results in a more real world use case in stats/DigestBuilderBenchmark show that this is a real winner.

Reviewed By: djwatson

Differential Revision: D7828158

fbshipit-source-id: e195b9739ce931a67a39ffb9715a228aef59f6bc

Summary: Some infrastructure sends `SIGQUIT` to stuck processes and we would like to be able to log stacktraces for these.

Reviewed By: yfeldblum

Differential Revision: D7819980

fbshipit-source-id: d99a1232ca259bd95aed82505751e6591af748ff

Summary:
Just re-running it on newer hardware:

32 processors
model name      : Intel(R) Xeon(R) CPU E5-2660 0 @ 2.20GHz

Reviewed By: yfeldblum

Differential Revision: D7828138

fbshipit-source-id: 30a25c6bf7bd0294f32f7598c701b49f045ab235

Summary: Small change so that a template class `ExtractFirstArg` can do the same thing without relying on an expensive header, `boost/type_traits.hpp`.

Reviewed By: yfeldblum

Differential Revision: D7781675

fbshipit-source-id: 1e5f431217da6cdd31ba1d77a8fc2b19a43808aa

Summary: In a test build `<iterator/iterator_facade>` showed up as the most heavyweight include.  Remove this include, dependency on the boost lib, and implement whatever's needed for the bidirectional iterator interface.

Reviewed By: yfeldblum

Differential Revision: D7781659

fbshipit-source-id: 380e0ae85b18c245845f479b2d268fdd3e16d54a

Summary:
Promote the folly logging code out of the experimental subdirectory.
We have been using this for several months in a few projects and are pretty
happy with it so far.

After moving it out of the experimental/ subdirectory I plan to update
folly::Init() to automatically support configuring it via a `--logging` command
line flag (similar to the initialization it already does today for glog).

Reviewed By: yfeldblum, chadaustin

Differential Revision: D7755455

fbshipit-source-id: 052db34c97f7516728f7cbb1a5ad959def2f6efb

Summary: As title. We were special casing q == 1 or q == 0 improperly before. This led to some strange results where p100 < p99.9. Track min and max (useful anyway), and use those for boundaries.

Reviewed By: anakryiko

Differential Revision: D7800645

fbshipit-source-id: 5fa3e1d0d286d4b31442196ba74b072030706786

Summary: This should fix running tests in a vcpkg environment.

Reviewed By: yfeldblum

Differential Revision: D7822368

fbshipit-source-id: a549febeb0bbea7208386cbed8a6ecb316b98661

Summary: Because Windows doesn't have `uint` as it's non-standard.

Reviewed By: djwatson

Differential Revision: D7821774

fbshipit-source-id: 4f7ff4468fc56052e28995f386e194fe70c6c513

Summary: Because it makes Visual Studio's intellisense happier, and it's always better to match exactly, rather than matching implicitly.

Reviewed By: yfeldblum

Differential Revision: D7821865

fbshipit-source-id: 9e2380884b2d8d12944e3a3fc921e532208b1791

Summary:
And move it to folly::python namespace.
We are going to make the python bridge work with fibers. This will require to make changes to this executor that are quite specific for the python use case.
It doesn't hurt to remove YetAnotherExecutor choice from the main executor directory.

Reviewed By: yfeldblum

Differential Revision: D7811125

fbshipit-source-id: eec21ccbbbad58aaa795df661ba58f67fa177645

Summary:
As per discussions on D7784214, to be consistent with the functions used by the
integral_hasher, mark these `noexcept`. Not much benefit for this diff other
than consistency.

Reviewed By: yfeldblum

Differential Revision: D7797826

fbshipit-source-id: 382c82556efd261841f3f6fb2ae892d26f3ceb0b

Summary:
Currently we'll are getting incorrect Idle&Busy time counters for loops when there were no LoopCallbacks. This is because we don't properly refresh the `startWork_` and use the one from the last loop that had LoopCallbacks.

This diff fixes that by properly refreshing `startWork_` even if there're no LoopCallbacks.

Reviewed By: yfeldblum

Differential Revision: D7811127

fbshipit-source-id: 94ded08963b1bddc7b7859484f076d4c8a1e897f

Summary: Fix shadown warning for xplat builds

Reviewed By: yfeldblum

Differential Revision: D7811636

fbshipit-source-id: 609b5acaca3cfdd11059ed1ebbaa969e281487a2

Summary:
Calling connect on the UDP socket can avoid route lookups
on the write path. This would be an optimization that would be
useful for clients.

There are several caveats of using connect() which we discovered
during testing. These are documented and unit tests have been written
for each of them.

Reviewed By: yfeldblum

Differential Revision: D7802389

fbshipit-source-id: 09b71373a3a95c5dab73ee9345db0dbbf66d4ec5

Summary: Some links are complaining of multiple definitions. Move to the cpp file to resolve.

Reviewed By: yfeldblum

Differential Revision: D7806874

fbshipit-source-id: f25342d647505b676ba3659400c63d6a59344024

Summary: This header is no longer needed since D7687476.

Reviewed By: yfeldblum

Differential Revision: D7804756

fbshipit-source-id: 6596f5296965b593ab5b0decf4c67203e19b03c8

Summary: As title

Reviewed By: tageorgiou

Differential Revision: D7804647

fbshipit-source-id: 9a58de258cd49a4d15ded05163975304c0e7e83b

Summary: This worked in clang but not in gcc. Quick fix

Differential Revision: D7800576

fbshipit-source-id: fcd04c0779f8a176043f3dede61289830a1ef607

Summary: Introduces two QuantileEstimators. Both estimators use the TDigest for estimating quantiles, and giving accurate sum, count, and mean. One estimator uses a single digest, and the other uses a SlidingWindow of 60 digests. All writes to the data structure are buffered for 1 second.

Reviewed By: anakryiko

Differential Revision: D7645824

fbshipit-source-id: 4f1f2c25388c3280f148591502449f857c6467d3

Summary: [Folly] Use `invoke_result` v.s. `std::result_of`, which is deprecated.

Reviewed By: aary, ericniebler

Differential Revision: D7771480

fbshipit-source-id: 1d89d489be98bfbe2014f2d6b5fc037f02147876

Summary: [Folly] Cut unused alias `isFutureResult`.

Reviewed By: Orvid

Differential Revision: D7787146

fbshipit-source-id: 44ed51e9e04c71530f67fc6dceb76b247dcadb55

Summary:
The test was missing a `main` meaning that it would fail even if libc++ was in use, making all the rest fail on macos for example.
Closes https://github.com/facebook/folly/pull/831

Reviewed By: Orvid

Differential Revision: D7787115

Pulled By: yfeldblum

fbshipit-source-id: 4a10323298be3f26f783fa1257cbde2483fb75b9

Summary:
The libstdc++ implementation of `std::unordered_map|set` determines whether to
cache a per-node hash code based on (1) whether the supplied hasher is fast
(true by default) and (2) whether the hashing operation will throw.

Mark the `operator()` of hashers of numeric types (integral, float, enum)
`noexcept`, such that stl unordered containers won't cache a hash code. This is
essentially free memomy savings, as comparing the cached hash code is as
expensive as comparing the numerical types directly.

Reviewed By: luciang

Differential Revision: D7784214

fbshipit-source-id: 020e1c38265f33a482b6ba913a11f1a383e840f8