Summary: [Folly] Write `/* static */ if` as `if /* constexpr */`. Once the time comes to jump to C++17, all that remains is to remove the comments.

Reviewed By: aary

Differential Revision: D9627826

fbshipit-source-id: 56078e727a3a4420851f1c441783b80da55a8e6c

Summary:
Folly warning correction -- the author clearly intended unsigned math

Fixes #923.

Reviewed By: yfeldblum

Differential Revision: D9508962

fbshipit-source-id: 0ffa1b25f7c427030987cc5ba03c6e7f160a335b

Summary: [Folly] Less duplication in `AtomicStruct` test.

Reviewed By: aary

Differential Revision: D9601770

fbshipit-source-id: c11fe49e081079f4c33b9d80c9b44437202390d9

Summary: [Folly] Cut explicit `decltype`-based return types in `folly/gen/File-inl.h` - they only required pre-gcc49.

Reviewed By: Orvid

Differential Revision: D9601484

fbshipit-source-id: 8750091a9ef3e4ba8b8f4e26a96b28fe8d242e7a

Summary:
[Folly] Pull out a local variable in `MMapAlloc`.

Moves the conditional compilation out of a compilcated expression and into a separate full-statement by itself.

Reviewed By: Orvid

Differential Revision: D9598437

fbshipit-source-id: 770c835f729e72b880aadcefb8aae7ead2754bd9

Summary: Because.

Reviewed By: yfeldblum

Differential Revision: D9568442

fbshipit-source-id: 0a1ecf1904499afa9069d345d70279a527e31b1a

Summary: As a mitigation for an `folly::dynamic` iteration order dependency on iOS.

Reviewed By: yfeldblum

Differential Revision: D9614129

fbshipit-source-id: 09a822a32327fd5389e8e4d169ab3af4f428426c

Summary:
I want to access the list of deps without the install
instructions attached later in this stack of diffs in `shell_builder.py`.

Refs: https://github.com/facebook/watchman/pull/639

Reviewed By: snarkmaster

Differential Revision: D9552419

fbshipit-source-id: 333cfa0c33bc1aa623de7ac3546a8f1785869a4f

Summary:
This is a bit of a tricky issue; here's the bug in python 2.7
that prevents using the function-like syntax:
https://bugs.python.org/issue21591

The nature of this bug is that scoped exec only works with nested functions
when using the `exec` statement in 2.7.   That is a syntax error in python 3,
which only allows using the `exec` function.

To make the function syntax work in 2.7 we therefore need to avoid using
lambdas or nested functions and have to resort to using a global variable
to act as the "closure".

Refs: https://github.com/facebook/watchman/pull/639

Reviewed By: snarkmaster

Differential Revision: D9552413

fbshipit-source-id: a2cb9d325e18fb6fb06b9e284a84f0a0c80cfe7e

Summary: Per T33416893, D9441402 caused a regression in FB4A. Goal: reenable lvalue-qual Future::onError(). Make it deprecated to minimize the chances of anyone creating new callsites.

Reviewed By: yfeldblum

Differential Revision: D9597490

fbshipit-source-id: 9c6a34c37c8f576e2497164bd440cdbc3565920d

Summary:
[Folly] Use `static_cast` v.s. C cast in `folly/Expected.h`.

And don't have empty namespaces - at least have a comment.

Reviewed By: igorsugak

Differential Revision: D9596449

fbshipit-source-id: 6b5b712d7d46eba4a83b7f62c0628a8bcda1f722

Summary: [Folly] Formatting of `FOR_EACH` etc uses.

Reviewed By: Orvid

Differential Revision: D9595505

fbshipit-source-id: bdb506f8904de2577c42ada6755a2af4f3efb095

Summary:
In `folly::symbolizer::ElfFile`, we `mmap` the file and access the file content via `mmap`-ed pointer directly. This is nice and efficient, but causes the whole program crashes on `SIGBUS` is the underlying frile is broken.

This Diff changes the first read of the file, for ELF magic number, to use `read` syscall and check return result, instead of accessing the `mmap`-ed pointer directly. This way APIs like `ElfFile::openNoThrow` would return error instead of crashing if the underlying file is broken.

It still doesn't solve the problem if the file becomes broken between we read the ELF magic number and we read file content with the `mmap`-ed file pointer later. But this is the best effort to check for the case with minimal performance cost.

Reviewed By: yfeldblum

Differential Revision: D9474328

fbshipit-source-id: 969e0323fcb4011e6a080d914452c9215d2fd13c

disable on android, fix getAllocatedMemorySize test to account for implementation-defined bucket_count for default containers

Summary:
This serves as a mitigation until we look further into the android crashes we
discovered in android instrumentation tests.

The bucket_count of the default constructed `unordered_map` is
implementation-defined. This diff takes that into account in the
`getAllocatedMemorySize` test.

`unordered_map|set` impl in Android NDK does not match the assumptions made in
`visitAllocationClasses`. Temporarily disable the tests with that method.

Reviewed By: mzlee

Differential Revision: D9578626

fbshipit-source-id: 355940b026f00f783bf65c2f1e10725d5aa920d3

Summary:
I noticed this while testing some changes; the comment
doesn't seem to match up to the `raise` statement, and attempting
to throw a list fails in python.

Reviewed By: strager

Differential Revision: D9566018

fbshipit-source-id: 563e43dfd30867993cc2a0f816db3b835a52e6df

Summary:
When running on macOS there is no /etc/issue.  When running
with `set -e` enabled, we don't want this to break the build.

Neither of these is possible today, but will be later in this diff stack.

While I'm in here, also print out the cmake version.

Refs: https://github.com/facebook/watchman/pull/639

Reviewed By: snarkmaster

Differential Revision: D9552416

fbshipit-source-id: 432b5b70678908de9f79787d37c3615a7f8649d3

Summary: Support for building Folly with autoconf is going away; this isn't going to keep working, so remove it.

Reviewed By: yfeldblum, philipjameson

Differential Revision: D9569019

fbshipit-source-id: 1fe99453c741ff9fc8632bbcfdd69df6b1f86d01

Summary: This means that Windows builds no longer require pthreads in order to run tests. (previously we were relying on the pthreads implementation we were using to provide semaphore.h for us)

Reviewed By: yfeldblum

Differential Revision: D9568125

fbshipit-source-id: 712f542c9a29627f72b41e1def2b79d591a33317

Summary: It's not a perfect mapping, but it's good enough.

Reviewed By: yfeldblum

Differential Revision: D9569405

fbshipit-source-id: 7559fb94f8a57717b5a594be0c05a99ac88c6c6e

Summary: The `(get|set)rlimit` stub implementations don't support setting memory limits, and I have no intention of implementing it, so disable it, as there are no meaningful memory limits on Windows to begin with.

Reviewed By: yfeldblum

Differential Revision: D9569424

fbshipit-source-id: 738d73f90eb33957ca4a80cb9b3c568034ef141e

Summary:
gcc8 fails compilation with:
    error: taking address of temporary array
      return {+A{Cs..., Char(0)}, sizeof...(Cs)};
So leverage c++14 to base manipulations on a local array.

Reviewed By: yfeldblum, ericniebler, Orvid

Differential Revision: D9310662

fbshipit-source-id: 0ba375ac0a4cca913e437290bc277c0c6bb8fdc8

Summary: These need to be escaped (they also don't work on Windows)

Reviewed By: yfeldblum

Differential Revision: D9566079

fbshipit-source-id: a202673c7cea62f3534ceff9cb81ee84aca65049

Summary: Platforms such as MSVC.

Reviewed By: yfeldblum

Differential Revision: D9569093

fbshipit-source-id: 3d836d5f660b610eed47a6692bc0ce33396fbfa5

Summary: as title

Reviewed By: Orvid

Differential Revision: D9568603

fbshipit-source-id: b5ce1ba8163af87f3ec6369407e3f8546e80afb1

Reviewed By: JunqiWang

Differential Revision: D9564136

fbshipit-source-id: 3eeb42e1629fdadfee758c3b9c92e167e126c946

Summary: This should work, probably.

Reviewed By: yfeldblum

Differential Revision: D9566267

fbshipit-source-id: 052295702a46edd85471c75ca82937dc3a508577

Summary: Because Bits.h feels the need to exercise all variants of popcount.

Reviewed By: yfeldblum

Differential Revision: D9565298

fbshipit-source-id: 307b3e4a70216c76d63104853e91e36a340ff1ab

Summary: MSVC wasn't treating this as an initializer list construction, so make it do so.

Reviewed By: yfeldblum

Differential Revision: D9565470

fbshipit-source-id: 15465b5c87a427920a7cad3f5204bb661ba230c2

Summary: Because, rather impressively, it wasn't being included transitively by anything here when compiling on Windows.

Reviewed By: yfeldblum

Differential Revision: D9565417

fbshipit-source-id: b83fa0b121d83cbeb7ff0bd79dec506b6549385e

Summary: MSVC defines timeval in a weird place, so include the portability header.

Reviewed By: yfeldblum

Differential Revision: D9564726

fbshipit-source-id: f9e43225a889bfb0395178ef809aaa81fb9ccc36

Summary: One of these warnings is informational, the other we will continue to blissfully ignore until either includes become cheap, or the eventual heat death of the universe, whichever comes first.

Reviewed By: yfeldblum

Differential Revision: D9565514

fbshipit-source-id: e5a8d8c868c122d4b06635b061540c8f329ec93d

Summary: Because the latter was removed in C++17, and MSVC no longer supports it.

Reviewed By: yfeldblum

Differential Revision: D9565195

fbshipit-source-id: 7603ac5280ccf540abec296c7c76a43142581eb3

Summary: Because if you tried to capture them, they wouldn't be usable as template arguments.

Reviewed By: yfeldblum

Differential Revision: D9565384

fbshipit-source-id: 9c4579848be1c5c48251c17b0f55443aade75eba

Summary: Because the former is standard and the latter doesn't exist on Windows.

Reviewed By: yfeldblum

Differential Revision: D9565344

fbshipit-source-id: c29c0623c87a20d4c16a29fec1a7311907c1c1cf

Summary: Not all platforms have pthread.

Reviewed By: yfeldblum

Differential Revision: D9565232

fbshipit-source-id: fced220115315f976dbea8c037869cb6aef461fd

Summary: Because forking is not a thing on Windows.

Reviewed By: yfeldblum

Differential Revision: D9565259

fbshipit-source-id: 140103d0df3b6d2d70a8e7d4eac96682e3430143

Summary:
Without this, `folly::gen`'s other `byLine()` implementations only
support a single read pass (usually through the whole input file) without
support for different formats through the file.

Reviewed By: yfeldblum

Differential Revision: D9540396

fbshipit-source-id: 6539851a70aed9a88d3c61986a459f60dfb7be5b

Summary:
Update readFull() and related functions to warn if their return value is
ignored.  Callers should pretty much always need to examine the return value,
as they need this to determine how much valid data was read.

Reviewed By: yfeldblum, meyering

Differential Revision: D9526760

fbshipit-source-id: c090044256bfe4bf9907a24ec6090eeae04296b3

Summary:
Files opened by `readFile()` should not be propagated to children processes
if another thread happens to spawn a subprocess while `readFile()` is running.

Reviewed By: yfeldblum, meyering

Differential Revision: D9553354

fbshipit-source-id: 2a6028b3a920bb1e76cd0b07f82e6af57d01c2a4

Summary:
A `CustomLogFormatter` can be enabled by setting the `formatter` option to `custom`. This formatter reads an option named `log_format` which specifies the format of the logs. The format string is similar to what `folly::vformat(format,...)` expects. Check out the following example format:

  {L}{m:02d}{D:02d} {H:02d}:{M:02d}:{S:02d}.{USECS:06d} {THREAD:5d} {FILE}:{LINE}]

The format above prints logs in the same format as GLOGs.

Another option `colored` takes in one of the following values: `never`, `auto`, and `always`. When enabled, the output will be colored in the following way:

{F135233848}

The config used for the image above is:
  FOLLY_INIT_LOGGING_CONFIG(".=DBG; default:formatter=custom,log_format={L} {FILE}::{FUN}():{LINE}],colored=true");

As you can see, we have also included the function name using `{FUN}`. This can be particularly helpful when debugging errors.

Reviewed By: simpkins

Differential Revision: D8974950

fbshipit-source-id: 87d624f53dd67c0630fb222093c46fe79ff44ee1